Insert using Foreach

Question

I am not really familiar with array.

I try to save my data to database but its seem not working the only it save was please check my sample image.

Fields

and the database it only save was

and it loop 4times

my codes below

<form method="post">
<table>
    <tr>
        <td>F Name</td>
        <td>M Name</td>
        <td>L Name</td>
    </tr>
    <tr>
        <td><input type="text" name="fname" value="" /></td>
        <td><input type="text" name="mname" value="" /></td>
        <td><input type="text" name="lname" value="" /></td>
    </tr>
    <tr>
        <td><input type="text" name="fname" value="" /></td>
        <td><input type="text" name="mname" value="" /></td>
        <td><input type="text" name="lname" value="" /></td>
    </tr>
</table>
<br />
<input type="submit" name="SubmitText" value="Save" />
</form>

if ( isset( $_POST['SubmitText'] ) ) {
    $fn = $_POST['fname'];
    $mn = $_POST['mname'];
    $ln = $_POST['lname'];
    $value = array();

    foreach( $_POST as $keys => $value)
    $db = mysql_query( "INSERT INTO jon_test VALUE( '', '".$value['fn']."', '".$value['mn']."', '".$value['ln']."' )" );

    echo $value['fn'] . '<br />';
    echo $db == true ? 'Yes' : 'No';
}

is there anything wrong with my codes?

Obligatory: The mysql_* functions will be deprecated in PHP 5.5. It is not recommended for writing new code as it will be removed in the future. Instead, either the MySQLi or PDO and be a better PHP Developer. — Jason McCreary
– Jason McCreary, Commented Jul 9, 2013 at 14:41
How about everything. Everything is wrong with your code. 1. you're not escaping your strings, enabling sql injections. 2. you don't indent your code making it unreadable and thus prone to errors. 3. you're using mysql_* functions which are deprecated. Use mysqli or PDO. — max_
– max_, Commented Jul 9, 2013 at 14:42

lexmihaylov · Accepted Answer · 2013-07-09 14:52:25Z

2

<form method="post">
<table>
    <tr>
        <td>F Name</td>
        <td>M Name</td>
        <td>L Name</td>
    </tr>
    <tr>
        <td><input type="text" name="input[0][fname]" value="" /></td>
        <td><input type="text" name="input[0][mname]" value="" /></td>
        <td><input type="text" name="input[0][lname]" value="" /></td>
    </tr>
    <tr>
         <td><input type="text" name="input[1][fname]" value="" /></td>
        <td><input type="text" name="input[1][mname]" value="" /></td>
        <td><input type="text" name="input[1][lname]" value="" /></td>
    </tr>
</table>
<br />
<input type="submit" name="SubmitText" value="Save" />
</form>

After that you will need to iteratate the post parameters:

foreach($_POST['input'] as $input) {
    $db = mysql_query( "INSERT INTO jon_test VALUE( '', '".$input['fname']."', '".$input['mname']."', '".$input['lname']."' )" );

   echo $input['fname'] . '<br />';
   echo $db == true ? 'Yes' : 'No';
}

edited Jul 9, 2013 at 14:52

answered Jul 9, 2013 at 14:43

lexmihaylov

7373 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

lexmihaylov Over a year ago

@user1538668 your code is vulnerable to sql injections, it's good if you use PDO or Mysqli with prepared statements to escape the values before they are inserted in the database. php.net/manual/en/book.mysqli.php php.net/manual/en/book.pdo.php

Butternut Over a year ago

yes i have class of mysqli its just that i used this mysql for test only. sorry next time i will post my class for mysqli

Butternut Over a year ago

thank you I apply it to my system, it works not on my WebShop @lexmihaylov

lexmihaylov Over a year ago

sorry don't think i understood you right, so it is NOT working on your website. If that is the case could you post some code that we could review

Mathlight · Accepted Answer · 2013-07-09 14:36:58Z

2

Wrap your PHP code within <?php ?> tags like this:

<?php
if ( isset( $_POST['SubmitText'] ) ) {
    $fn = $_POST['fname'];
    $mn = $_POST['mname'];
    $ln = $_POST['lname'];
    $value = array();

    foreach( $_POST as $keys => $value)
    $db = mysql_query( "INSERT INTO jon_test VALUE( '', '".$value['fn']."', '".$value['mn']."', '".$value['ln']."' )" );

    echo $value['fn'] . '<br />';
    echo $db == true ? 'Yes' : 'No';
}
?>

Also, i recommend you use mysqli_* functions instead of mysql_* functions, because mysql_* functions are deprecated and will be removed in the futere.

answered Jul 9, 2013 at 14:36

Mathlight

6,73318 gold badges66 silver badges109 bronze badges

1 Comment

Timber Over a year ago

I think the OP knows that already, maybe he forgot to type the tags in the questions. He managed to insert a few things to the database already.

VeNoMiS · Accepted Answer · 2013-07-09 14:38:18Z

1

input name are the same so you get only the last result use [] to create an array of values

answered Jul 9, 2013 at 14:38

VeNoMiS

3305 silver badges16 bronze badges

Collectives™ on Stack Overflow

Insert using Foreach

3 Answers 3

4 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related