if inside for each loop pushing multidimensional array - php

Question

I'm running two for each loops and pushing one of them into the other one. This works fine, except if my I have more than one match. In that case, I'm only getting the last one. Sorry about the title, not too sure how to call this question in one line.

foreach($items as &$item) {
    foreach($fruits as &$fruit) {
        $i = 0;
        if($fruit['for']==$item['id']) {
            $item["fruits"][$i] = $fruit;
            $i++;
        }
    }
}

First array :

array(114) {
  [0]=>
  array(5) {
    ["id"]=>
    string(2) "76"
    ...
  }
...
}

Second array :

array(47) {
  [0]=>
  array(5) {
    ["id"]=>
    string(1) "4"
    ["for"]=>
    string(2) "76"
    ...
  }
  ...
}

With multiple matches of the if($fruit['for']==$item['id']) logic, I'd like the following output.

array(114) {
  [0]=>
  array(6) {
    ["id"]=>
    string(2) "76"
    ...
    ["fruits"]=>
    array(2) {
      [0]=>
      array(5) {
        ["id"]=>
        string(1) "4"
        ["for"]=>
        string(2) "76"
        ...
      }
      [1]=>
      array(5) {
        ["id"]=>
        string(2) "33"
        ["for"]=>
        string(2) "76"
        ...
      }
    }
  }
}

What am I doing wrong?

Mithun Sreedharan · Accepted Answer · 2013-07-15 08:02:41Z

2

take $i outside the loop, your match is always stored in $item["fruits"][0]

foreach($items as &$item) {
    $i = 0;   
    foreach($fruits as &$fruit) {
        if($fruit['for']==$item['id']) {
            $item["fruits"][$i] = $fruit;
            $i++;
        }
    }
}

edited Jul 15, 2013 at 8:02

answered Jul 15, 2013 at 7:54

Mithun Sreedharan

51.6k72 gold badges185 silver badges237 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

veksen Over a year ago

$i = 0; inside the first loop is the result I want, but thanks for pointing me in the right direction :)

Lars Ebert-Harlaar · Accepted Answer · 2013-07-15 07:55:35Z

1

You set $i to 0 for every array-element you check. This renders the $i++ useless and your first match gets overwritten. Try either this:

foreach($items as &$item) {
    $i = 0;
    foreach($fruits as &$fruit) {
        if($fruit['for']==$item['id']) {
            $item["fruits"][$i] = $fruit;
            $i++;
        }
    }
}

or this: (depending on what exactly you will need)

$i = 0;
foreach($items as &$item) {
    foreach($fruits as &$fruit) {
        if($fruit['for']==$item['id']) {
            $item["fruits"][$i] = $fruit;
            $i++;
        }
    }
}

That way, each time you find a new match it gets a new key.

answered Jul 15, 2013 at 7:55

Lars Ebert-Harlaar

3,5373 gold badges26 silver badges47 bronze badges

1 Comment

veksen Over a year ago

so that was it.... thank you! I'm not sure how to feel, proud that I'm getting so close (php is new to me), or sad that I didn't see my error. Thank you very much!

Collectives™ on Stack Overflow

if inside for each loop pushing multidimensional array - php

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related