Laravel 4: undefined variable error when submitting data from the view

Question

I'm trying building a timer app - this form should submit the time (which it does) AND the client name as populated from the database, it looks like this:

{{ Form::open(array('action' => 'TasksController@store', 'name' => 'timer')) }}
    {{ Form::select('client', $client , Input::old('client')) }}
    {{ Form::hidden('duration', '', array('id' => 'val', 'name' => 'duration')) }}
    {{ Form::submit('Submit', array('class' => 'btn btn-primary')) }}
{{ Form::close() }}

My controller that generates this page looks like this:

public function index()
{
    $client = DB::table('clients')->orderBy('name', 'asc')->lists('name','id');
    return View::make('tasks.index', compact('task', 'client'));
}

I am getting a "Undefined variable: client" when I submit the form. I can't see why.

What am I doing wrong?

EDIT: the store function in my TasksController looks like this:

public function store()
{
    $input = Input::all();  
    $v = Validator::make($input, Task::$rules);
    if($v->passes())
    {
        $this->task->create($input);
        return View::make('tasks.index');
    }
    return View::make('tasks.index')
        ->withInput()
        ->withErrors($v)
        ->with('message', 'There were validation errors.');
}

Show us store method from TasksController - you say that's the point where execution fails — Andreyco
– Andreyco, Commented Jul 16, 2013 at 19:27
You wouldnt have a $client variable in your controller - you'd have Input::get('client') — Laurence
– Laurence, Commented Jul 17, 2013 at 1:19
@Andreyco, check my edit please - what is the best way to add the $client variable into my controller? — Josh
– Josh, Commented Jul 17, 2013 at 2:04

Laurence · Accepted Answer · 2013-07-17 03:48:07Z

2

You are returning the View::make() from your store() function, which is not the 'resourceful' way of doing it.

Your view is expecting to have $client included in it - but because store() does not return a $client - the error is generated.

Assuming you are using a resourceful controller - your store function should look like this:

public function store()
{
    $input = Input::all();  
    $v = Validator::make($input, Task::$rules);
    if($v->passes())
    {
        $this->task->create($input);
        return Redirect::route('tasks.index');  // Let the index() function handle the view generation
    }
    return Redirect::back()  // Return back to where you came from and let that method handle the view generation
        ->withInput()
        ->withErrors($v)
        ->with('message', 'There were validation errors.');
}

answered Jul 17, 2013 at 3:48

Laurence

60.2k22 gold badges178 silver badges215 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Josh Over a year ago

Thank you, that's amazing it's throwing it into the database, only one issue - I get the error: "Unable to generate a URL for the named route "tasks.index" as such route does not exist" my route looks like this: Route::resource('/', 'TasksController'); I've always had this issue with my laravel apps but never understood it. Sorry if this is a bit of a silly question.

Laurence Over a year ago

it should be Route::resource('tasks', 'TasksController);

Collectives™ on Stack Overflow

Laravel 4: undefined variable error when submitting data from the view

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related