ASP.NET dynamic Command Button event not firing

You have to wire it up like this (in C#):

myButton.Click += new EventHandler(this.Button_Clicked);

Alternatively you can inject the attribute --> onclick = "Button_Clicked" like this:

myButton.Attributes.Add("onclick", "Button_Clicked");

If you want it in VB.NET go to this page and knock yourself out - I could do it for you but what's the point :)

EDIT: keep in mind you'll have to re-wire the event-handler (as shown above) every page-load.

EDIT: OK - I see the problem now that you added the rest of the code. You are wiring up the event handler on pre_render. Event handlers are executed just before load_complete, which happens before pre_render. This is why you event_handler doesn't execute: you're adding it too late in the page lifecycle. Put that code in the page_load routine and it should work.

I had this same problem, I was loading the controls just fine. the events were firing the first time, but not the second time. The problem was I didn't have a unique identifier tied to the controls. So I added a unique ID field to the control I was adding to the page, and it worked just fine, every click.

You need to wire up the click event. See this code...

Partial Class _Default
    Inherits System.Web.UI.Page

    Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load

        Dim button1 As New Button
        Dim button2 As New Button

        button1.ID = "button1"
        button1.Text = "Button 1"
        button2.ID = "button2"
        button2.Text = "Button 2"

        AddHandler button1.Click, AddressOf OnClick
        AddHandler button2.Click, AddressOf OnClick

        form1.Controls.Add(button1)
        form1.Controls.Add(button2)

    End Sub

    Private Sub OnClick(ByVal sender As Object, ByVal e As System.EventArgs)

        Dim buttonId As String

        buttonId = DirectCast(sender, Button).ID

        Response.Write("Button clicked: " + buttonId)

    End Sub

End Class

Hope this helps...

Correct way is:

1. OnLoad - generate dynamic content (create dynamic buttons)
2. Button OnClick - consume event and regenerate correct content

But it requires to generate content twice - once for create buttons to process events and then erase old content and generate correct one - second time. You can workaround it like this:

1. OnLoad - check if buton was clicked
2. PreRender - generate correct content with dynamic buttons (content is generated only once)

My example to do that:

<script type="text/javascript" language="javascript">
    function SetPostBackAction(Action,ReturnValue)
    {
        if(ReturnValue)
            document.getElementById('<%=hfPostBackAction.ClientID%>').value=Action;
        return ReturnValue;
    }
</script>
<asp:HiddenField ID="hfPostBackAction" EnableViewState="false" runat="server" />

And in code:

protected void Page_PreRender(object sender, EventArgs e)
{
    //Dynamic button in PreRender
    System.Web.UI.WebControls.Button btn=new System.Web.UI.WebControls.Button()
    btn.ID=string.Format("DeleteButton_SomeData{0}", 12345);
    btn.Text="Delete";
    btn.OnClientClick=string.Format("return SetPostBackAction('DeleteButton_SomeData{0}',window.confirm('Are you sure to delete?'))", 12345);
    btn.Click+=new EventHandler(btnDelete_Click);//This method will not be called if button is created in PreRender
}

protected void Page_Load(object sender, EventArgs e)
{
    //Do something...
    //Check Action
    ProccessAction();//You can check action whereever you want
}

protected void ProccessAction()
{
    string Action=Request.Form[hfPostBackAction.UniqueID]??string.Empty;
    int SomeData;

    if(Action.StartsWith("DeleteButton_"))//Is action?
    {
        SomeData=int.Parse(Action.Substring("DeleteButton_SomeData".Length));
        //Do something...
    }
    //Erase Action field not to fire action next time accidentially
    hfPostBackAction.Value=string.Empty;
}