Validation with controller method accepting just a string

Question

Say I have a controller method, that accepts just a string:

[HttpPost]
public ActionResult DoSomething(string emailAddress)
{
    //
}

How could I validate that emailAddress isn't null...? Obviously I can't use DataAnnotations, as I don't have a model?

the naive question is why not just use a model. You might have one parameter now, but adding another in the future would be easier and less likely to break the method signature. Just my 2 cents. — Khalid Abuhakmeh
– Khalid Abuhakmeh, Commented Jul 22, 2013 at 13:37
In an agile way of working, the additional complexity of creating a model would be done as and when needed. With one property, it's not needed — Alex
– Alex, Commented Jul 22, 2013 at 13:42
I would say the added noise in the controller action (from the solutions) would warrant that tiny additional complexity, but that's just my personal preference. Rules are made to be broken when the solution makes more sense than the constraint. — Khalid Abuhakmeh
– Khalid Abuhakmeh, Commented Jul 22, 2013 at 13:45

Alex · Accepted Answer · 2013-07-22 11:59:03Z

2

How about just

[HttpPost]
public ActionResult DoSomething(string emailAddress)
{
    if (string.IsNullOrWhiteSpace(emailAddress))
    {
        ModelState.AddModelError("emailAddress", "Please enter an email");
    }
}

edited Jul 22, 2013 at 11:59

Alex

38.6k55 gold badges217 silver badges340 bronze badges

answered Jul 22, 2013 at 11:40

Andrei

56.8k10 gold badges92 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dlebech · Accepted Answer · 2013-07-22 11:42:11Z

1

This should work:

[HttpPost]
public ActionResult DoSomething(string emailAddress)
{
    if (string.IsNullOrEmpty(emailAddress))
        ModelState.AddModelError("emailAddress", "Email address is empty");

    if (ModelState.IsValid)
    {
        // Do something
    }

    return View();
}

To show the error, include a ValidationSummary in your view.

answered Jul 22, 2013 at 11:42

dlebech

1,83914 silver badges29 bronze badges

1 Comment

Venkata K. C. Tata Over a year ago

[ValidateInput(False)] [HttpPost] public ActionResult DoSomething(string emailAddress) .. this may help

Collectives™ on Stack Overflow

Validation with controller method accepting just a string

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related