Explode with operator

Question

I have a working code to restrict & validate subdomain.

 $exp = explode('.', 'blog.mydomain.my.');

 print_r($exp);
 if(count($exp) == 3 && $exp[1] == "mydomain" && $exp[2] == "my" || $exp[3] == "") {
    echo "<br>";
  echo 'subdomain valid';
 } else{
    echo "<br>";
  echo 'not valid';
 }

now it need to check if its only false and I'm not so sure about the $exp[3] != "" comparison. From example below the subdomain should be valid but it give me error.

 echo "<br>";echo "<br>";
 $exp2 = explode('.', 'blog.mydomain.my.');

 print_r($exp2);
 if(count($exp2) != 3 || $exp2[1] != "mydomain" || $exp2[2] != "my" || $exp[3] != "") {
    echo "<br>";
  echo 'not valid';
 }

Accepted numbers of subdomain is hello.mydomain.my or hello.mydomain.my. (with trailing dot). While hello.world.mydomain.my is not accepted.

Thanks in advance

I feel like either you should be checking if count($exp2) != 4 or you should take off the last condition, as if the count is 3 the last condition should go out of bounds — StephenTG
– StephenTG, Commented Aug 2, 2013 at 18:06

Orangepill · Accepted Answer · 2013-08-02 18:07:35Z

2

This should give you what you want.

if(count($exp2) < 3 || count($exp2) > 4 || $exp2[1] != "mydomain" || $exp2[2] != "my" || (count($exp2) != 4 && $exp[3] != "")) {
  echo "<br>";
  echo 'not valid';
}

answered Aug 2, 2013 at 18:07

Orangepill

24.7k3 gold badges44 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

AlexP Over a year ago

Why not regex? $valid = preg_match('/^hello\.domain\.my\.?$/', $domain) ? true : false;

Orangepill Over a year ago

@AlexP with a different subdomain pattern that would work as well. You should refine and post that as an answer...I would upvote

sg552 Over a year ago

just to understand your code.. subdomain will be not valid if ONE of the statement match the criteria and to be valid all statement must not match the criteria?

AlexP · Accepted Answer · 2013-08-02 21:10:42Z

2

I would go for a regex solution, possibly even encapsulate it in a function:

function isValidDomain($domain) 
{
  return preg_match('/^[\w]+\.(mydomain)\.(my)\.?$/', $domain) ? true : false;
}

var_dump(isValidDomain('www.google.com'));
var_dump(isValidDomain('test.invalid.domain'));
var_dump(isValidDomain('hello.mydomain.my'));
var_dump(isValidDomain('hello.mydomain.my.'));

edited Aug 2, 2013 at 21:10

answered Aug 2, 2013 at 18:50

AlexP

9,8571 gold badge28 silver badges44 bronze badges

2 Comments

Orangepill Over a year ago

I think the intent was for any subdomain to match so maybe '/^[\w]+\.(mydomain)\.(my)\.?$/'

sg552 Over a year ago

Yes any subdomain to match with my domain.

Collectives™ on Stack Overflow

Explode with operator

2 Answers 2

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related