if statement in bash not executing

Question

I am a beginner is bash and i really need some help here.The conditional part of the script is not executing for some reason. Here is my code

#!/bin/bash
#Checking Os
os=$(lsb_release -si)
echo $os
if [ $os == "CentOs" ]; then
echo 'success'
fi

Now part till echo $os works fine and out is

CentOs

but 'success' don't get output :(

Any idea why if part don't get executed.What is wrong with the syntax.I get no errors whatsoever

Brian Showalter · Accepted Answer · 2013-08-04 11:43:43Z

1

Linux is case sensitive. Running "lsb_release -a" on my CentOS install results in "CentOS" - note that the trailing "S" is uppercase. Change your code to test for the properly capitalized string, and it should work.

answered Aug 4, 2013 at 11:43

Brian Showalter

4,3572 gold badges29 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hek2mgl · Accepted Answer · 2013-08-04 13:24:09Z

1

Hope this helps:

#!/bin/bash
#Checking Os
os=$(lsb_release -si)

# !quote variables when passing them to commands like echo!
echo "$os"

# A space between ] and ; Quote "$os". Note: = instead of == is OK as well.
# Note that it's not CentOs, it's CentOS
if [ "$os" == "CentOS" ] ; then
  echo 'success'
fi

The ultimate reference: Advanced Bash Scripting Guide

edited Aug 4, 2013 at 13:24

answered Aug 4, 2013 at 11:06

hek2mgl

159k31 gold badges263 silver badges279 bronze badges

3 Comments

A.H. Over a year ago

Hhmm. My bash manual says, that = and == inside a conditional expression are equivalent.

hek2mgl Over a year ago

@A.H. Thx for the tip! I didn't know this. Also I would not say that I'm a bash guru. Just wanted to help the newbie opener a little bit. Have updated the post to prevent from giving useless information.....

user2650277 Over a year ago

Thanks but it still didn't work , sucess is still not echoed on my end , Only value of $os is display

Collectives™ on Stack Overflow

if statement in bash not executing

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related