STL string conversion between wstring and string

Question

I am wondering is this adequate enough to use in a production codebase?

std::wstring s2w(const std::string& s)
{
    std::wstring ws;
    ws.assign(s.begin(), s.end());
    return ws;
}

std::string w2s(const std::wstring& w)
{
    std::string s;
    s.assign(w.begin(), w.end());
    return s;
}

AFAIK, no, it isn't adequate, because it doesn't do any conversion (only narrowing). You'll have to do a real conversion between the narrow string encoding and the wide string encoding. For example, using codecvt<wchar_t,char,mbstate_t>, in C++11 probably combined with wstring_convert. — dyp
– dyp, Commented Aug 8, 2013 at 12:35

Marshall Clow · Accepted Answer · 2013-08-08 16:29:50Z

0

No, this is not sufficient.

Consider a wstring that contains the following characters (numeric values used for clarity) { 0x41, 0x1243, 0x62 } (That's 'A', followed by ETHIOPIC SYLLABLE QAA, followed by 'b' if you're using Unicode).

Converting to a string using your routine would result in a sequence containing { 0x41, 0x43, 0x42 }, or 'ACb'. Probably not what you expected - or wanted.

As DyP said - you're not doing any conversion, only narrowing.

answered Aug 8, 2013 at 16:29

Marshall Clow

16.8k2 gold badges36 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

STL string conversion between wstring and string

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related