Trying to use IoC for asp.net mvc 4, "No parameterless constructor defined for this object" exception

Question

I am trying to setup IoC using StructureMap for my ASP.NET MVC 4 site. Here is my StructureMapDependencyResolver class:

    public class StructrueMapDependencyResolver : IDependencyResolver
    {        
        public object GetService(Type serviceType)
        {
            return IocContainer.GetInstance(serviceType);
        }

        public IEnumerable<object> GetServices(Type serviceType)
        {
            return IocContainer.GetAllInstances(serviceType);
        }
    }

Here is part of my IocContainer

public static class IocContainer
{
    ....

    public static object GetInstance(Type t)
    {
        return ObjectFactory.TryGetInstance(t);
    }

    public static IEnumerable<object> GetAllInstances(Type t)
    {
        return ObjectFactory.GetAllInstances(t).Cast<object>();
    }
}

Here is what my Global.aspx.cs looks like

public class MvcApplication : System.Web.HttpApplication
    {
        protected void Application_Start()
        {
            AreaRegistration.RegisterAllAreas();

            WebApiConfig.Register(GlobalConfiguration.Configuration);
            FilterConfig.RegisterGlobalFilters(GlobalFilters.Filters);
            RouteConfig.RegisterRoutes(RouteTable.Routes);

            IocContainer.RegisterAllTypes(Server.MapPath("~\\Bin"), AssemblyList.MyAssemblies);
            DependencyResolver.SetResolver(new StructrueMapDependencyResolver());
        }
    }

Finally I have a simple controller that depends on a service:

  public class ManagePostController: Controller
  {
      private ISomeService _someService;

      public ManagePostController(ISomeService svc)
      {
          _someService= svc;
      }
  }

When I start my website, got the following exception:

No parameterless constructor defined for this object.

[InvalidOperationException: An error occurred when trying to create a controller of type 'Foothill.WebAdmin.Controllers.ManagePostController'. Make sure that the controller has a parameterless public constructor.] System.Web.Mvc.DefaultControllerActivator.Create(RequestContext requestContext, Type controllerType) +247

I am not sure where I need to change?

No @WiktorZychla I dont think that's the case. The MSDN page for IDependencyResolver doesn't mention anything about being WebApi only. — sean717
– sean717, Commented Aug 11, 2013 at 18:00

Community · Accepted Answer · 2020-06-20 09:12:55Z

4

Replace your IocContainer.GetInstance(Type) implementation with the following:

public static object GetInstance(Type t)
{
    return t.IsAbstract || t.IsInterface
                    ? ObjectFactory.TryGetInstance(t)
                    : ObjectFactory.GetInstance(t);
}

The ASP.NET MVC extensibility model will attempt to resolve various components (e.g. IControllerActivator) which are optional (if you return null, MVC will use the default components instead). That's why we have the ObjectFactory.TryGetInstance call - this will only resolve a component if you explicitly configure it within the container.

For resolving controllers (which are concrete types) ObjectFactory.GetInstance should be used - this creates an instance even though the controller type was never explicitly configured.

The code snippet above is what I use in my projects and I just realized it's very similar to what is present in the StructureMap MVC4 Nuget package (see line 123 in this file).

By the way, I think you could simply use the NuGet package instead of going through these steps yourself.

Update

Regarding IControllerActivator: that's just another extensibility point. If no controller activator is registered, the dependency resolver is used instead:

If there is no IControllerActivator present in the dependency resolver, we will then ask the dependency resolver to create the concrete controller type by calling GetService(controllerType). (quote from Brad Wilson's blog)

Also, an explanation of why there are both IDependencyResolver and IControllerActivator: http://forums.asp.net/post/4241343.aspx

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Aug 11, 2013 at 18:30

Cristian Lupascu

40.8k18 gold badges107 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

sean717 Over a year ago

Thanks @w0lf, it works now. But I still have the following question: Since I want to use the default controller activator, so I didn't register any concrete controller activator type in SM. Therefore ObjectFactory.TryGetInstance(t) will return null for a t == controller activator. And this will make the MVC4 to fall over to the default activator. Am I right?

Steven Over a year ago

The contract of the IDependencyResolver's GetService method states that "Implementers should return Nothing when the service cannot be found.". In other words, the implementation should always call TryGetInstance; not conditionally.

Cristian Lupascu Over a year ago

@Steven that works if all the Controllers in the application are manually configured in the container. StructureMap, however, offers this feature that it can (attempt to) resolve concrete types even though they are not explicitly configured.

Steven Over a year ago

Other containers (Castle, Ninject, Simple Injector) have this same behavior, but I'm not sure why that's relevant. If the container can resolve that instance (whether or not it is registered directly or not), it should resolve that instance (unless of course TryGetInstance does not resolve unregistered concrete types). But even if the container can resolve unregistered concrete types, it is still very advisable to register all your controllers explicitly to prevent this problem

Cristian Lupascu Over a year ago

@Steven Exactly: in StructureMap TryGetInstance will return null for a non-registered concrete type, whereas GetInstance will perform the resolution. Thanks for pointing out the WebAPI problem; I haven't been aware of that.

|

fbarikzehy · Accepted Answer · 2015-05-25 13:51:54Z

0

I had the same problem using IoC container and googled for hours about it but could not get rid of it.finally I install last update of Visual Studio(VS Version 2013 and update3 in my case) and the probelm get solved.

answered May 25, 2015 at 13:51

fbarikzehy

5,5252 gold badges38 silver badges41 bronze badges

Collectives™ on Stack Overflow

Trying to use IoC for asp.net mvc 4, "No parameterless constructor defined for this object" exception

2 Answers 2

Update

6 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Update

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related