Read the XML with different elements in C#

Question

I know, that there are a lot of question about parsing C#, but I couldn't find answer. So, I need to write a DLL for parsing XML, but with some features, as I don't know what elements are in XML file. I need to parse all nodes of file and their elements. How can I do it? Now, I'm working with simple file

<reg>
    <email_login>[email protected]</email_login>
    <email_password>nDOUn3TybD</email_password>
</reg>

and my dll code now is

public XmlNodeList GetElementsName(string path)
{
    XmlDocument xmlDoc = new XmlDocument();
    xmlDoc.Load(path);
    XmlNodeList nodeList = xmlDoc.GetElementsByTagName("email_login");
    return nodeList;
}

It should return "[email protected]". My console app:

XMLWorker worker = new XMLWorker();
string path = "file:///D:/temp/test.xml";
XmlNodeList nodeList = worker.GetElementsName(path);
for (int i = 0; i < nodeList.Count; i++)
    Console.WriteLine(nodeList[i].InnerText);
Console.ReadLine();

But it returns "[email protected]"

How can I parse differently?

Also confirm what @azyberezovsky says, this works fine for me. The result is [email protected] by itself — SwDevMan81
– SwDevMan81, Commented Aug 13, 2013 at 14:08
@Henk Holterman, that username/password was generated by small app) But who knows...) — Sashko Chehotsky
– Sashko Chehotsky, Commented Aug 13, 2013 at 14:14

Sergey Berezovskiy · Accepted Answer · 2013-08-13 14:07:50Z

3

Use LINQ to XML:

XElement reg = XElement.Load(path);
string login = (string)reg.Element("email_login");

BTW your code works fine for me. Make sure you are not selecting all elements instead of email_login only. I.e. if you are getting child nodes XmlNodeList nodeList = xmlDoc.ChildNodes; instead of getting elements by tag name, then you will have your results.

Or possibly you have several elements named as email_login. E.g. following xml will produce your results with your code:

<reg>
  <email_login>[email protected]</email_login>
  <email_login>nDOUn3TybD</email_login>
</reg>

edited Aug 13, 2013 at 14:07

answered Aug 13, 2013 at 14:01

Sergey Berezovskiy

237k44 gold badges441 silver badges468 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

No Idea For Name · Accepted Answer · 2013-08-13 14:07:11Z

0

i ran the exact same code you gave and got [email protected] as output so my guess is that you haven't build your project after you fixed something or it wasn't cleaned.

try to clean the project and run it again

answered Aug 13, 2013 at 14:07

No Idea For Name

11.7k11 gold badges49 silver badges73 bronze badges

Comments

Anirudha · Accepted Answer · 2013-08-13 14:11:12Z

0

You can do it this way

public List<String> getElementValues(string path,string elementName)
{
    XElement doc= XElement.Load(path);
    var elementList=doc.Descendants().Elements();
    return elementList.Where(x=>x.Name.LocalName==elementName)
                      .Select(y=>y.Value)
                      .ToList();
}

You can now get all the values of element with name email_login

var values=getElementValues(path,"email_login");

edited Aug 13, 2013 at 14:11

answered Aug 13, 2013 at 14:05

Anirudha

32.9k8 gold badges71 silver badges90 bronze badges

Comments

Praveen Prajapati · Accepted Answer · 2013-08-13 14:13:56Z

0

I ran following code after coping the XML data you provided in XMLFile.xml to emulate output:

class Program
{
    static void Main(string[] args)
    {
        XMLWorker worker = new XMLWorker();
        //
        string path = @"C:\Users\abc\Desktop\ConsoleApplication1\ConsoleApplication1\XMLFile.xml";
        XmlNodeList nodeList = worker.GetElementsName(path);
        for (int i = 0; i < nodeList.Count; i++)
        Console.WriteLine(nodeList[i].InnerText);
        Console.ReadLine();
    }       
}

public class XMLWorker
{
    public XmlNodeList GetElementsName(string path)
    {
        XmlDocument xmlDoc = new XmlDocument();
        xmlDoc.Load(path);
        XmlNodeList nodeList = xmlDoc.GetElementsByTagName("email_login");

        return nodeList;
    }
}

But for me it is working fine.

answered Aug 13, 2013 at 14:13

Praveen Prajapati

9891 gold badge17 silver badges22 bronze badges

2 Comments

Sergey Berezovskiy Over a year ago

That was already said by me, by NoIdeaForName, and by SwDevMan81 in comments

Praveen Prajapati Over a year ago

Yes...now lets see what we get here causing the issue !!

Nir Kornfeld · Accepted Answer · 2013-08-13 14:16:56Z

0

You can also use XPath query:

XmlNodesList nodesList = xmlDoc.SelectNodes("//email_login"));
foreach(string oneNode in nodesList) 
{
    Console.Write(oneNode.InnerText);
}

answered Aug 13, 2013 at 14:16

Nir Kornfeld

8277 silver badges11 bronze badges

Collectives™ on Stack Overflow

Read the XML with different elements in C#

5 Answers 5

Comments

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related