Can I make this Javascript code shorter?

Question

I'm just starting programming, can I make this code shorter? Maybe with an array? Thanks.

function createDragName1(){
    var firstName;
    var random1 = Math.floor((Math.random()*17)+0);
    var name1 = "va";
    var name2 = "tuul";

    switch(random1){
        case 0:
            firstName = name1;
            break;
        case 1:
            firstName = name2;
            break;
        default:
            firstName = "Error";
    }

    var testingName = firstName.substring(0,1).toUpperCase()+firstName.substring(1,6);

    return(testingName);

}

Why are you multiplying by 17? Do you really want to return "Error" over 88% of the time? — Ted Hopp
– Ted Hopp, Commented Aug 22, 2013 at 2:43
Let me count for you: +0, 4 extra var statements, unnecessary temporary variable, parentheses around return, Math.random, default switch case that could be coded with a default value, yes, you can make it shorter. — Antti Haapala
– Antti Haapala, Commented Aug 22, 2013 at 2:46

Ja͢ck · Accepted Answer · 2013-08-22 02:44:29Z

1

Sure, you can use a map:

function createDragName1(){
    var random1 = Math.floor(Math.random() * 17), // [0, 17)
    names = ['Va', 'Tuul']; // title cased names

    return names[random1] || 'Error';
}

The expression names[random1] || 'Error' returns a name if 0 <= random1 < names.length and 'Error' otherwise.

I've also removed the title case logic by manually title casing names.

Btw, the random number will in most cases be outside of the desired range, so you will return Error an awful many times.

answered Aug 22, 2013 at 2:44

Ja͢ck

174k39 gold badges269 silver badges317 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

plalx Over a year ago

Put the array inline in the return statement and it's even shorter ;)

Ja͢ck Over a year ago

@plalx Doing that would degrade the code readability though :)

user2003548 · Accepted Answer · 2013-08-22 02:46:20Z

0

function createDragName1(){

    var random1 = Math.floor((Math.random()*17)+0);
    var firstName = ["va","tuul"][random1];
    if(!firstName){
       firstName = 'Error';
    }

    var testingName = firstName.substring(0,1).toUpperCase()+firstName.substr(1);

    return(testingName);

}

answered Aug 22, 2013 at 2:46

user2003548

4,5755 gold badges29 silver badges34 bronze badges

Comments

Ted Hopp · Accepted Answer · 2013-08-22 02:51:17Z

Assuming you want to return either "Va" or "Tuul" with equal probability, and don't really want to return "Error":

function createDragName1() {
    return Math.random() < 0.5 ? "Va" : "Tuul";
}

However, if you do want the original behavior:

function createDragName1() {
    var rand = 17 * Math.random();
    return rand < 1 ? "Va" : rand < 2 ? "Tuul" : "Error";
}

A general method for picking a random name out of an array is:

var array = ["Va", "Tuul"];
var randomElement = array[0 | (array.length * Math.random())];

(The weird notation 0 | x evaluates to the integer part of x because the bitwise | operator converts arguments to integer if necessary.) If you want an expanded range:

var array = ["Va", "Tuul"];
var randomElementOrError = array[0 | (17 * Math.random())] || "Error";

plalx · Accepted Answer · 2013-08-22 02:56:34Z

0

I don't think you can make it much shorter than:

function createDragName1() {
    return ['Va', 'Tuul'][Math.floor(Math.random() * 17)] || 'Error';
}

answered Aug 22, 2013 at 2:56

plalx

43.8k7 gold badges77 silver badges94 bronze badges

Collectives™ on Stack Overflow

Can I make this Javascript code shorter?

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related