Javascript changing iframe src doesn't work

Question

On my website I wrote a function like this:

function apri(dat) {
document.getElementId('dado').src= dat;
}

and the iframe HTML code is the following.

<iframe id="dado"src="http://mk7vrlist.altervista.org/" width="100%" height="700px" scrolling="yes" frameBorder="0">
  Your browser doesn't load this iframe.
</iframe>

I call the apri() function in this way:

<p onclick="apri(http://mk7vrlist.altervista.org/other/staffpage.html)"> <img src="/pictures/uno.png" /> Staffers</p>

The content of my iframe is not changing. I've googled this a lot but I didn't find any solution. What can I do?

Do you think I should use something different instead of the iframe?

You have 'getElementId'. Did you mean 'getElementById' ?

fred02138
– fred02138

2013-08-28 12:59:14 +00:00
Commented Aug 28, 2013 at 12:59 — fred02138
– fred02138, Commented Aug 28, 2013 at 12:59

epascarello · Accepted Answer · 2013-08-28 12:49:33Z

4

Check your error console after you click the text. You will see an error message.

SyntaxError: missing ) after argument list

The bug is quoting problem. You have a string with no quotes around it.

<p onclick="apri('http://mk7vrlist.altervista.org/other/staffpage.html')">
                 ^                                                    ^
              missing                                               missing

answered Aug 28, 2013 at 12:49

epascarello

208k20 gold badges206 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Alberto Rossi Over a year ago

I found another error I made. If you look at apri() I wrote 'document. getElementId ('dado').src=', It should be getElementById. Add this in the answer, it could help other users ;)

Collectives™ on Stack Overflow

Javascript changing iframe src doesn't work

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related