String output query

Question

I am new to this comunity and I am seeking advise on how to improve my current script. Below is the code:

if (condition1 == true) string stringname  = "dog";
if (condition2 == true) string stringname1 = "cat";
if (condition3 == true) string stringname2 = "mouse";
if (condition4 == true) string stringname3 = "crab";

Format.String("Animal Type: {0}, {1}, {2}, {3}", stringname, stringname1, stringname2, stringname3); // print to output

Specifically what I would like is to be able to display the result in the output window in the following way:

example 1: assuming condition 1 and 3 are true and 2 and 4 are false: "Animal Type: dog, mouse" Whilst with my current script I would get: "Animal Type: dog,, mouse,"

example 2: assuming condition 2 and 3 are true: "Animal Type: cat, mouse" Whilst with my current script I would get: "Animal Type: ,cat, mouse,"

Ehsan · Accepted Answer · 2013-08-30 11:42:52Z

3

var animals = new List<string>();
if (condition1) animals.Add("dog");
if (condition2) animals.Add("cat");
if (condition3) animals.Add("mouse");
if (condition4) animals.Add("crab");
string result = "Animal Type: " + string.Join(", ", animals);

edited Aug 30, 2013 at 11:42

Ehsan

32.9k6 gold badges61 silver badges66 bronze badges

answered Aug 30, 2013 at 11:39

Thomas Levesque

294k73 gold badges639 silver badges769 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2732622 Over a year ago

this really helped thanks! what if I know that the output can be only 1 of the names in the list, how should I adjust my result field? thanks

Adriaan Stander · Accepted Answer · 2013-08-30 11:39:36Z

0

Firstly, to join the strings, I would look at using

String.Join Method

Concatenates the members of a constructed IEnumerable(Of T) collection of type String, using the specified separator between each member.

So you can try something like

List<string> vals = new List<string>();
if (condition1) vals.Add("dog");
if (condition2) vals.Add("cat");
if (condition3) vals.Add("mouse");
if (condition4) vals.Add("crab");

And then try something like

Format.String("Animal Type: {0}, String.Join(",", vals));

answered Aug 30, 2013 at 11:39

Adriaan Stander

167k32 gold badges294 silver badges288 bronze badges

1 Comment

user2732622 Over a year ago

this really helped thanks! what if I know that the output can be only 1 of the names in the list, how should I adjust my result field? thanks

Rowland Shaw · Accepted Answer · 2013-08-30 11:40:46Z

The closest direct match would be something along the lines of:

console.WriteLine(string.Format("Animal Type: {0}, {1}, {2}, {3}", (condition1 ? "dog", ""), (condition2 ? "cat", ""), (condition3 ? "mouse", ""), (condition4 ? "crab", ""))); // print to output

With your code you're declaring the variable only for the scope of the if.

Another approach would be to push them into a list, for example, something like:

var selected = new List<string>();
if (condition1 == true) selected.Add("dog");
if (condition2 == true) selected.Add("cat");
if (condition3 == true) selected.Add("mouse");
if (condition4 == true) selected.Add("crab");

console.WriteLine(string.Format("Animal Type: {0}", string.Join(", ", selected.ToArray()))); // print to output

Ehsan · Accepted Answer · 2013-08-30 11:42:28Z

0

i would do it with a HashSet like this

 var animals = new HashSet<string>();
 if (condition1) animals.Add("dog");
 if (condition2) animals.Add("cat");
 if (condition3) animals.Add("mouse");
 if (condition4) animals.Add("crab");
 string result = "Animal Type: " + string.Join(", ", animals);

answered Aug 30, 2013 at 11:42

Ehsan

32.9k6 gold badges61 silver badges66 bronze badges

4 Comments

user2732622 Over a year ago

this really helped thanks! what if I know that the output can be only 1 of the names in the list, how should I adjust my result field? thanks

Ehsan Over a year ago

example of your input and output you expect?

user2732622 Over a year ago

var animals = new HashSet<string>(); if (condition1) animals.Add("dog"); if (condition2) animals.Add("cat"); if (condition3) animals.Add("mouse"); if (condition4) animals.Add("crab"); string result = "only 1 of the above conditions, e.i. mouse" assumption is that only 1 of the 4 conditions above can be true

Ehsan Over a year ago

even in that case the above answer is correcy. You will get a valid answer.

Harold Sota · Accepted Answer · 2013-08-30 11:42:46Z

0

 string output = "Animal Type: ";
            if (condition1 == true) output  += "dog ,";
            if (condition2 == true) output += "cat ,";
            if (condition3 == true) output += "mouse ,";
            if (condition4 == true) output += "crab ,";

            output = output.Substring(0, output.Length - 2);

answered Aug 30, 2013 at 11:42

Harold Sota

7,58613 gold badges60 silver badges85 bronze badges

Comments

Dom84 · Accepted Answer · 2013-08-30 11:47:39Z

0

I would say, defining a list of strings and putting in your values if true would be the solution. After that, Join it with semicolon as delimiter.

List<string> outList = new List<string>();
if (true) outList.Add("dog");
if (false) outList.Add("cat");
if (true) outList.Add("mouse");
if (false) outList.Add("crab");
Console.Write(String.Format("Animal Type: {0}", String.Join(",", outList)));

answered Aug 30, 2013 at 11:47

Dom84

8669 silver badges22 bronze badges

Collectives™ on Stack Overflow

String output query

6 Answers 6

1 Comment

1 Comment

Comments

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

1 Comment

Comments

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related