PHP Check if user is logged in with a function

Question

I'm working on a website and the index page checks if the user is logged in or not with this piece of code:

if (!$_SESSION['login'] && $_SESSION['login'] == "") {
include_once($_SERVER['DOCUMENT_ROOT'] . "/login/");
} elseif ($_SESSION['login'] == 1) {
include_once($_SERVER['DOCUMENT_ROOT'] . "/main/");
}

But I want it to look cleaner, then I started wondering if was possible to achieve something like this with a function:

checklogin($_SESSION['login']);

I don't have much experience with functions, so i'm sorry if my question looks stupid, so thanks in advance.

Don't worry, both snippets you posted are perfectly valid. It's up to you how to structure your code and where to put the logic. But it must be somewhere. So if you just want that function (as in the second example), the logic from the previous example will have to be inside that function. It can't just go away. You should re-use an existing authentication framework whenever possible, because, really, it's complex. For example, take a look at github.com/delight-im/PHP-Auth which is both framework-agnostic and database-agnostic. — caw
– caw, Commented Oct 21, 2016 at 21:30

jayjay · Accepted Answer · 2013-08-30 16:10:08Z

6

Try this

if(check_login()) {
  echo 'You are in!';
} else {
    header('Location: login.php');
    exit;
}

function check_login () {
    if(isset($_SESSION['login'] && $_SESSION['login'] != '') {
       return true;
    } else {
       false;
    }
}

edited Aug 30, 2013 at 16:10

jayjay

592 silver badges9 bronze badges

answered Aug 30, 2013 at 15:55

user2533445

864 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Joseph Silber · Accepted Answer · 2013-08-30 15:57:36Z

3

Just use empty:

if ( empty($_SESSION['login']) ) {
    include_once($_SERVER['DOCUMENT_ROOT'] . "/login/");
} else {
    include_once($_SERVER['DOCUMENT_ROOT'] . "/main/");
}

Or condense it:

include_once $_SERVER['DOCUMENT_ROOT'].(empty($_SESSION['login']) ? "/login/" : "/main/");

answered Aug 30, 2013 at 15:57

Joseph Silber

221k59 gold badges369 silver badges293 bronze badges

Comments

Lkopo · Accepted Answer · 2013-08-30 15:59:50Z

2

There is what you need:

function userCheck()
{
    return (isSet($_SESSION['login']) && $_SESSION['login']);
}

if(userCheck())
    include_once($_SERVER['DOCUMENT_ROOT'] . "/main/");
else
    include_once($_SERVER['DOCUMENT_ROOT'] . "/login/");

answered Aug 30, 2013 at 15:59

Lkopo

4,8538 gold badges37 silver badges60 bronze badges

Comments

bfilipesoares · Accepted Answer · 2013-08-30 15:59:57Z

1

Disregarding the fact of whether or not your approach makes sense, I think this would do what you expect:

function checklogin($login){
      if (!$login && $login == "") {
          include_once($_SERVER['DOCUMENT_ROOT'] . "/path/");
      }
}


// **** call to the function

       checklogin($_SESSION['login']);  

// ****

answered Aug 30, 2013 at 15:59

bfilipesoares

1471 silver badge11 bronze badges

Comments

jayjay · Accepted Answer · 2013-08-30 16:04:09Z

0

You can use this function:

function checklogin() {
  return (isset($_SESSION['login'])) ? true : false;
}

then on pages you want to check whether the user is logged in or not, you can:

if(checklogin() === true){
  //here you would put what you want to do if the user is logged in
} else {
  //this would be executed if user isn't logged in
  header('Location: protected.php');
  exit();
  //the above would redirect the user
}

answered Aug 30, 2013 at 16:04

jayjay

592 silver badges9 bronze badges

Collectives™ on Stack Overflow

PHP Check if user is logged in with a function

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related