jquery .attr() not working on an input element

Question

http://jsfiddle.net/uz79M/ Here's my pretty simple code, can anyone tell me why the hell it wont start working xD I'm missing something silly ain't I? Why does the damn value remain on ="test"?

Thanks for reading!

(P.S.: Did I get my tags right or should I delete/replace some of them?)

jsfiddle.net/uz79M/1 i have made the change and share it . val will work — Devesh
– Devesh, Commented Sep 5, 2013 at 10:33
wow the reaction time on this by you guys was amazing xD I'll give everyone +1 once I get to the 15 rep ^_^ Thank you so much everyone! — MrHappy
– MrHappy, Commented Sep 5, 2013 at 10:37

Arun P Johny · Accepted Answer · 2013-09-05 10:38:29Z

15

use .val() to change the value of an input element

jQuery('input[name="prop_sc_AttachmentType"]').val(selectvalue);

Ex: (I've done some more clean up in the code)

jQuery(function ($) {
    $("#AttachmentTypeSelect").change(function () {
        var selectvalue = $(this).val();
        if (selectvalue !== "select") {
            $('input[name="prop_sc_AttachmentType"]').val(selectvalue);
        }
    });
});

Demo: Fiddle

Also the use of .attr() was wrong, it should be

$(element).attr(attribute, value)

ex

$(element).attr('tab-index', 1)

edited Sep 5, 2013 at 10:38

answered Sep 5, 2013 at 10:32

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

tea2code · Accepted Answer · 2013-09-05 10:32:34Z

5

Your code is not correct, it should be

.attr('value', selectValue );

or better

.val( selectValue );

answered Sep 5, 2013 at 10:32

tea2code

1,0071 gold badge8 silver badges15 bronze badges

Comments

Behzad Hassani · Accepted Answer · 2013-09-05 10:37:18Z

5

The attr an prop functions of jquery selector are for the attributes which don't have function for that selector. if you want to check or change the value of an input you should call val() function of selector. change your code to this :

jQuery('input[name="prop_sc_AttachmentType"]').val(selectvalue);

answered Sep 5, 2013 at 10:37

Behzad Hassani

2,1394 gold badges32 silver badges55 bronze badges

Comments

Sudhir Bastakoti · Accepted Answer · 2013-09-05 10:32:04Z

3

change:

 jQuery('input[name="prop_sc_AttachmentType"]').attr('value="' + selectvalue + '"');

to

jQuery('input[name="prop_sc_AttachmentType"]').val(selectvalue);

answered Sep 5, 2013 at 10:32

Sudhir Bastakoti

100k15 gold badges163 silver badges169 bronze badges

Comments

Rory McCrossan · Accepted Answer · 2013-09-05 10:32:12Z

3

Firstly your attr() syntax is incorrect, it should be attr('prop', 'value');, secondly to set a value, you should use val() anyway. Try this:

jQuery('input[name="prop_sc_AttachmentType"]').val(selectvalue);

Example fiddle

answered Sep 5, 2013 at 10:32

Rory McCrossan

338k41 gold badges322 silver badges353 bronze badges

Comments

Parfait · Accepted Answer · 2013-09-05 10:33:23Z

3

attr() change to val()

jQuery('input[name="prop_sc_AttachmentType"]').val(selectvalue);

http://jsfiddle.net/uz79M/3/

answered Sep 5, 2013 at 10:33

Parfait

1,7501 gold badge11 silver badges12 bronze badges

Comments

Mohsen · Accepted Answer · 2013-09-05 10:35:10Z

3

it is

.attr( attributeName, value )

so it will be

jQuery('input[name="prop_sc_AttachmentType"]').attr('value',selectvalue);

answered Sep 5, 2013 at 10:35

Mohsen

2691 silver badge3 bronze badges

Comments

giorgio · Accepted Answer · 2013-09-05 10:32:56Z

2

You should use val() to change it's value:

jQuery('input[name="prop_sc_AttachmentType"]').val(selectValue);

The attribute property is better used for other attributes like title, name etc.

answered Sep 5, 2013 at 10:32

giorgio

10.2k2 gold badges30 silver badges41 bronze badges

Comments

semuzaboi · Accepted Answer · 2013-09-05 10:34:44Z

2

Instead of

    if (selectvalue !== "select") {
        jQuery('input[name="prop_sc_AttachmentType"]').attr('value="' + selectvalue + '"');
    }

Use

  if (selectvalue !== "select") {
        jQuery('input[name="prop_sc_AttachmentType"]').val( selectvalue);
    }

Fair trade !:)

answered Sep 5, 2013 at 10:34

semuzaboi

5,2125 gold badges23 silver badges36 bronze badges

1 Comment

semuzaboi Over a year ago

Wow ... 8 answers before i finished typing :D !

RONE · Accepted Answer · 2013-09-05 10:35:12Z

2

You have to use .val() function,

jQuery('input[name="prop_sc_AttachmentType"]').val(selectvalue); //standard

Or you can correct your code :

jQuery('input[name="prop_sc_AttachmentType"]').attr('value', selectvalue);

FIDDLE DEMO

answered Sep 5, 2013 at 10:35

RONE

5,5059 gold badges45 silver badges78 bronze badges

Comments

Indra Yadav · Accepted Answer · 2013-09-05 10:38:58Z

2

Here is working code

and here is fiddle

jQuery(document).ready(function () {
    var selectvalue = jQuery("select#AttachmentTypeSelect").val();
    jQuery("select#AttachmentTypeSelect").change(function () {
        alert("d")
        selectvalue = jQuery("select#AttachmentTypeSelect").val();
        alert(selectvalue);
        if (selectvalue !== "select") {
            $('input[name="prop_sc_AttachmentType"]').attr('value', selectvalue);
        }
    });
});

answered Sep 5, 2013 at 10:38

Indra Yadav

5965 silver badges22 bronze badges

Comments

Nishu Tayal · Accepted Answer · 2013-09-05 10:40:03Z

2

Use following :

jQuery(document).ready(function () {
    var selectvalue = jQuery("select#AttachmentTypeSelect").val();

    jQuery("select#AttachmentTypeSelect").change(function () {
        selectvalue = jQuery("select#AttachmentTypeSelect").val();

        if (selectvalue !== "select") {
        jQuery('input[name="prop_sc_AttachmentType"]').val(selectvalue);
        }
    });
});

answered Sep 5, 2013 at 10:40

Nishu Tayal

20.9k8 gold badges53 silver badges105 bronze badges

Comments

q0re · Accepted Answer · 2013-09-05 11:38:10Z

2

You can set the value directly with the .val methode.

Replace this:

jQuery('input[name="prop_sc_AttachmentType"]').attr('value="' + selectvalue + '"');

with

jQuery('input[name="prop_sc_AttachmentType"]').val(selectvalue);

edited Sep 5, 2013 at 11:38

answered Sep 5, 2013 at 10:35

q0re

1,35719 silver badges33 bronze badges

4 Comments

Fluffeh Over a year ago

It is good form to add an explanation to an answer when providing code itself. While your code may be correct, unless the OP understands why, it is really giving a man a fish, not teaching them to fish - which is what SO is all about.

q0re Over a year ago

Yes, i would edit my answer after posting, but i see that so many people also gives the true answer.. ;)

Fluffeh Over a year ago

I came across this because it had been flagged as a poor quality answer. It doesn't matter how many other answers there are - your answer is a statement that depicts YOU. If you want to answer, answer it as if there were no other answers at all. At the end of the day, one answer will be accepted. Do the best you can to make it yours :)

q0re Over a year ago

Thank you, i will do it better ;)

Krichevskoy · Accepted Answer · 2013-09-27 04:21:20Z

1

try this:

jQuery(document).ready(function () {
        var selectvalue = jQuery("select#AttachmentTypeSelect").val();
        jQuery("select#AttachmentTypeSelect").change(function () {
            alert("d")
            selectvalue = jQuery("select#AttachmentTypeSelect").val();
            alert(selectvalue);
            if (selectvalue !== "select") {
                $('input[name="prop_sc_AttachmentType"]').attr('value', selectvalue);
            }
        });
    });

answered Sep 27, 2013 at 4:21

Krichevskoy

2542 silver badges17 bronze badges

Comments

Sumit Kumar · Accepted Answer · 2013-10-01 06:10:03Z

0

Perhaps you are not using attr function correctly:

this should be like this

$('selector').attr({value:desiredValue});

or

$('selector').attr('value',desiredValue);

But for setting values jQuery provides

$('selector').val(desiredValue);

answered Oct 1, 2013 at 6:10

Sumit Kumar

1,89219 silver badges20 bronze badges

Collectives™ on Stack Overflow

jquery .attr() not working on an input element

15 Answers 15

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Comments

Comments

Comments

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

15 Answers 15

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Comments

Comments

Comments

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related