C# - using value twice within object initialiser

Question

I have the below code I would like to adapt because it is calling multiple times on a lengthy event that I think could be avoided:

People= (from p in xDocument.Root.Descendants("People").Where(
                        se => Get<int>(se.Element("ID")) != i1)
          select new Person
              {
                 ID = Get<int>(se.Element("ID")),
                 Skills = GetPersonSkills(Get<int>(se.Element("ID")))
              }).OrderBy(w => w.FirstName).ToList()

How can I, instead of having the application rerun the Get(se.Element("ID")) method, just simply tell Skills = GetPersonSkills(ID). It would then just simply read its own ID value.

PS: The code I wrote here is not the actual lengthy code but simplified to demonstrate the purpose. I am aware that my Get(se.Element("ID")) example is not time consuming for the application but it was just to highlight the part of teh code that i would need to improve.

Tim Schmelter · Accepted Answer · 2013-09-06 10:54:40Z

2

Store it in an anonymous type:

People= xDocument.Root.Descendants("People")
    .Select(se => new { ID=Get<int>(se.Element("ID")) })
    .Where(x => x.ID != i1)
    .Select(x => new Person
          {
             ID = x.ID,
             Skills = GetPersonSkills(x.ID)
          }
    ).OrderBy(w => w.FirstName)
    .ToList();

answered Sep 6, 2013 at 10:54

Tim Schmelter

462k79 gold badges720 silver badges981 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vladimir · Accepted Answer · 2013-09-06 11:08:30Z

2

People = xDocument.Root.Descendats("People")
    .Select(se => Get<int>(se.Element("ID")))
    .Where(id => id != i1)
    .Select(id => new Person
        {
            ID = id,
            Skills = GetPersonSkills(id)
        })
    .OrderBy(w => w.FirstName)
    .ToList()

edited Sep 6, 2013 at 11:08

answered Sep 6, 2013 at 10:54

Vladimir

7,4954 gold badges39 silver badges41 bronze badges

Comments

dcastro · Accepted Answer · 2013-09-06 10:53:18Z

1

You could pass whatever Get<int>(se.Element("ID")) returns to the Person constructor, and have the constructor fill in its ID and Skills properties.

answered Sep 6, 2013 at 10:53

dcastro

69.1k22 gold badges150 silver badges159 bronze badges

Collectives™ on Stack Overflow

C# - using value twice within object initialiser

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related