MySQL SELECT query seems to skip spaces

Question

I'm a beginner with PHP and mySQL and I'm using it for my project. I sort of have a problem with my query.

This is my code:

    $doctname = mysql_query("SELECT name_of_doctor FROM {$table} WHERE department_no = '{$_REQUEST['deptno']}'");
    $doctnamerow = mysql_fetch_row($doctname);

    do
    {
        foreach ($doctnamerow as $cell)
        {
            $doctnamerowvalue = $cell;
        }
    } while ($doctnamerow = mysql_fetch_row($doctname));

So the problem I have is that if the doctor's name has a space between it (e.g "AJ Ramos") then it seems to skip the space and just returns "AJ" and not the surname. How do I do this? Thanks =)

edit:

Silly me, It was just an error with my code, I was using $doctnamerowvalue as a value=$doctnamerow for one of my text boxes and forgot to put double quotes, which resulted in value=doctor name and not value="doctor name". Sorry

How did you determine that your return value is truncated (please show the code). Also, what's the point of your foreach loop? — RandomSeed
– RandomSeed, Commented Sep 6, 2013 at 13:51
@RandomSeed thank you for reminding me to determine if my return value is truncated. It was simply an error with my syntax. I was using $doctnamerowvalue as a value for one of my text boxes, and forgot to put double quotes which resulted in value=doctor name and not value="doctor name". Thank you! — Timothy Buensuceso
– Timothy Buensuceso, Commented Sep 6, 2013 at 14:00

Vlad Preda · Accepted Answer · 2013-09-06 14:06:04Z

Flash Code Review:

mysql_* is deprecated. Use MySQLi or PDO.
Your code is wide open to SQL injection
$doctornamerowvalue is overwritten on every iteration
the foreach you are doing is pointless.
variable names are poorly chosen.

Here it is refactored:

// do these in a config file !!!
$db = new PDO('mysql:dbname=' . DB_NAME . ';host=localhost', DB_USER, DB_PASS);
$db->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_ASSOC); // if you want to use associative arrays

// here is the refactored code
$query = "SELECT name_of_doctor FROM `{$table}` WHERE department_no = :deptno";

$stmt = $db->prepare($query);
$stmt->execute(array(':deptno' => $_REQUEST['deptno']));
$doctors = $stmt->fetchAll();

foreach ($doctors as $doctor) {
     echo $doctor['name_of_doctor'] . '<br>';
}

Related to your 'bug'

Check the table structure and data. It's possible that the field contains only the surname, and there is another field that contains the name.
Check the table length - maybe it's too small, so the string is truncated.

marcin · Accepted Answer · 2013-09-06 13:56:21Z

0

try this:

$sql = "your sql syntax";
$result = mysql_query($sql);

$array_of_things = array();

while ($row = mysql_fetch_array($result)) {
    $array_of_things[] = $row['table_column_name'];
}

foreach($array_of_things as $val) {
    echo $val; 
}

answered Sep 6, 2013 at 13:56

marcin

971 gold badge3 silver badges10 bronze badges

Comments

Shakti Patel · Accepted Answer · 2013-09-06 14:01:57Z

0

used this :

$doctname = mysql_query("SELECT name_of_doctor FROM {$table} WHERE department_no = '{$_REQUEST['deptno']}'");
$doctnamerow = mysql_fetch_row($doctname);


while ($raw = mysql_fetch_row($doctname)) {
echo $raw['name_of_doctor'];
}

answered Sep 6, 2013 at 14:01

Shakti Patel

3,8624 gold badges24 silver badges30 bronze badges

Collectives™ on Stack Overflow

MySQL SELECT query seems to skip spaces

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related