Cannot insert multiple objects without calling SaveChanges() every time

Question

I'm trying to add several objects to the DB with EF ObjectContext without calling the SaveChanges() after each add. Problem is that only the last added object is committed to the DB.

using (var entities = new ModelEntities())
{
    foreach (service in services)
    {
       entities.Services.AddObject(service);
    }
    entities.SaveChanges();
}

When I call the SaveChanges() method directly after AddObject all objects are inserted but performance is affected. What am I doing wrong?

Thanks.

James · Accepted Answer · 2013-09-08 11:44:29Z

1

Try:

using (var entities = new ModelEntities())
{
    foreach (var s in services)
    {
       var service = s;
       entities.Services.AddObject(service);
    }
    entities.SaveChanges();
}

answered Sep 8, 2013 at 11:44

James

7,55310 gold badges50 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

undefined Over a year ago

I don't see why this would produce any different performance results, it looks the same to me. can you explain what this will do and why it affects performance?

James Over a year ago

It's not about performance. The original code wasn't working because EF only added the last object referenced by service when the loop had finished. Here, service is scoped within the loop so every object is added. (Perhaps someone can do a better job of explaining!)

Collectives™ on Stack Overflow

Cannot insert multiple objects without calling SaveChanges() every time

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related