Android: ListView Multiple Selection

Question

Problem:

When i click on the 2nd checkbox item in the listview then automatically 10th item is checked. I can not understand what's happen?

import java.util.ArrayList;
import java.util.List;

import android.app.Activity;
import android.content.Context;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.View.OnClickListener;
import android.view.ViewGroup;
import android.widget.ArrayAdapter;
import android.widget.CheckBox;
import android.widget.CompoundButton;
import android.widget.ImageButton;
import android.widget.TextView;

public class ItemAdapter extends ArrayAdapter<MyItem> {
private int resId;
Context context;
private ArrayList<MyItem> itemList;

public ItemAdapter(Context context, int textViewResourceId,
        List<MyItem> objects) {
    super(context, textViewResourceId, objects);
    this.context = context;
    this.resId = textViewResourceId;
    this.itemList = new ArrayList<MyItem>();
    this.itemList.addAll(objects);
}

private class ViewHolder {
    public boolean needInflate;
    public TextView txtItemName;
    public CheckBox chkItem;
}

@Override
public View getView(int position, View convertView, ViewGroup parent) {
    ViewHolder holder = null;
    MyItem cell = (MyItem) getItem(position);
    LayoutInflater mInflater = (LayoutInflater) context
            .getSystemService(Activity.LAYOUT_INFLATER_SERVICE);
    if (convertView == null) {
        convertView = mInflater.inflate(R.layout.listitem, null);
        holder = new ViewHolder();
        holder.txtItemName = (TextView) convertView
                .findViewById(R.id.tvItemName);
        holder.chkItem = (CheckBox) convertView.findViewById(R.id.chkItem);
        holder.chkItem
                .setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {

                    @Override
                    public void onCheckedChanged(CompoundButton buttonView,
                            boolean isChecked) {
                        //Log.i("Pos", "" + position);
                        //cell.setSelected(buttonView.isChecked());
                    }
                });
        convertView.setTag(holder);

    } else {
        holder = (ViewHolder) convertView.getTag();
    }

    holder.txtItemName.setText(cell.getName());
    return convertView;
  }
}

"MyItem" is my pojo Class.

OnCreate Code:

 lvItemName = (ListView) findViewById(R.id.lvItemName);
    List<MyItem> myItemsList = new ArrayList<MyItem>();

    for (int i = 0; i < items.length; i++) {
        MyItem item = new MyItem(items[i], false);
        myItemsList.add(item);
    }

    ItemAdapter adapter = new ItemAdapter(this, R.layout.listitem,
            myItemsList);
    lvItemName.setAdapter(adapter);
    lvItemName.setOnItemClickListener(this);

"items" is my String Array.

Thanks in Advance.

stackoverflow.com/questions/18162931/…. check this if it helps — Raghunandan
– Raghunandan, Commented Sep 9, 2013 at 9:53
I have problem with checkbox means when i checked 2nd checkbox item then automatically 10th item is checked. Can you please tell me what's wrong in my code? — Dhruv
– Dhruv, Commented Sep 9, 2013 at 10:01
@lawrance:you are not setting tag on checkeditem postion. I have suggested a link in my answer which fixes your issue. — user755
– user755, Commented Sep 9, 2013 at 10:03
@Lawrence check out this answer, it may help: stackoverflow.com/a/20171191/919216 — Chanakya Vadla
– Chanakya Vadla, Commented Nov 24, 2013 at 4:56

Ansar · Accepted Answer · 2013-09-09 10:08:24Z

1

I hope you can avoid this problem by

adding a boolean array like

boolean[] checkboxState=new boolean['your array size here']; //global decleration
holder.checkBox.setOnClickListener(new OnClickListener() {

            public void onClick(View v) {
                // TODO Auto-generated method stub

                if (((CheckBox) v).isChecked()) {
                    checkboxState[position] = true;


                } else
                    checkboxState[position] = false;

This works for me and i hope this will help you..

answered Sep 9, 2013 at 10:08

Ansar

3643 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user755 · Accepted Answer · 2013-09-09 10:18:47Z

0

set tag on checkeditem postion.

Check out here complete working example.

edited Sep 9, 2013 at 10:18

answered Sep 9, 2013 at 9:57

user755

2,6614 gold badges21 silver badges30 bronze badges

Comments

Pratik Dasa · Accepted Answer · 2013-09-09 10:20:53Z

0

In your listview getView method, make holder.checkbox to seTag(position).

Then use that position using getTag() method, you will get selected position there and your problem will solved. Read about setTag(value) and getTag() method.

answered Sep 9, 2013 at 10:20

Pratik Dasa

7,4494 gold badges32 silver badges44 bronze badges

Collectives™ on Stack Overflow

Android: ListView Multiple Selection

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related