correct javascript syntax for two or more strings in operator

Question

I wrote this piece of code, but I am not getting my syntax correct. I tried it several ways. The first one below seems like it should work, but I am not quite there yet. Please point me in the correct direction for what the correct syntax is when comparing multiple strings

$(document).ready(function() {
var url = window.location.pathname.substring(1);
if ( [ 'page_id=11', 'page_id=19'].indexOf( url ) > -1 ) { 
$('#main').css("background-color","#ebecee"); 
}
});

and I also tried like this

$(document).ready(function() {
var url = window.location.pathname.substring(1);
if(url.href.indexOf("page_id=11") > -1 && ("page_id=19") > -1 ) {
$('#main').css("background-color","#ebecee");
}
});

What is the correct way to write it?

There are many "correct" ways to write it. The problem is probably that your URL doesn't contain the value you think it contains. Try console.log(url). — user229044
– user229044 ♦, Commented Sep 12, 2013 at 0:55

Stephen P · Accepted Answer · 2013-09-12 01:03:27Z

1

"A shot in the dark"

Part of the problem may be that you're looking at window.location.pathname and in most cases something like page_id=19 is not part of the pathname -- it is part of the query.

Look at window.location.search instead to check just the query parameters, or, as the others suggested, look at the entire location by checking window.location.href or document.URL.

var query = window.location.search;
if (query.indexOf("page_id=11") > -1 || query.indexOf("page_id=19) > -1) {
    // do your stuff
}

answered Sep 12, 2013 at 1:03

Stephen P

14.9k2 gold badges50 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1725382 Over a year ago

Thanks the window.location.search was a great suggestion

OneOfOne Over a year ago

I up voted your answer, this is the correct one, for the life of me I couldn't remember window.location.search when I answered.

Simon M · Accepted Answer · 2013-09-12 00:54:54Z

0

If you're trying to check if either page_id=11 or page_id=19 is in your page's URL, this should work:

$(document).ready(function() {
    if(document.URL.indexOf("page_id=11") > -1 || document.URL.href.indexOf("page_id=19") > -1 ) {
        $('#main').css("background-color","#ebecee");
    }
});

answered Sep 12, 2013 at 0:54

Simon M

2,9412 gold badges24 silver badges37 bronze badges

Comments

OneOfOne · Accepted Answer · 2013-09-12 00:55:16Z

0

var url = location.href;
if(url.indexOf("page_id=11") > -1 || url.indexOf("page_id=19") > -1 ) {
    $('#main').css("background-color","#ebecee");
}

answered Sep 12, 2013 at 0:55

OneOfOne

100k22 gold badges195 silver badges187 bronze badges

1 Comment

user1725382 Over a year ago

Thanks this worked I also added window.location.search.substring(1);

Rameez · Accepted Answer · 2013-09-12 01:03:34Z

0

You can use localeCompare() method.

This method returns a number indicating whether a reference string comes before or after or is the same as the given string in sort order.

Syntax:

string.localeCompare( param )

Return Value:

0 : It string matches 100%.
1 : no match, and the parameter value comes before the string object's value in the locale sort order
-1 : no match, and the parameter value comes after the string object's value in the locale sort order

Your case

var index1 = location.href.localeCompare( "page_id=11" );
var index2 = location.href.localeCompare( "page_id=19" );

More

answered Sep 12, 2013 at 1:03

Rameez

1,7222 gold badges19 silver badges41 bronze badges

Collectives™ on Stack Overflow

correct javascript syntax for two or more strings in operator

4 Answers 4

2 Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related