Inserting data into a Database using PHP (errors but doesn't insert anything);

Question

Following tutorials I found online and this one basically was showing me how to insert data into a database. I have Database called JapaneseDefinition and I have the table named Japanesewords. I got HTML Code that sends Japaneseword and English into my Database.

I am able to look up a word with a different query, but I am having no such look with the INSERT Query. Can someone look at my code and tell me where I am going wrong with it.

                    try{
$conn = new PDO('mysql:host=Jamal-PC;dbname=japanesewords',$username,$password);
if(isset($_POST['EnglishWord'])){
$Japaneseword = $_POST ['JapaneseWord'];
$Englishword = $_POST['EnglishWord'];
$q = "INSERT INTO Japanesedefinition(Japaneseword,Englishword)VALUES(:Japaneseword,:Englishword):";
$query = $conn->prepare($q);
$result = $query->execute(array(
'Japaneseword'=>$Japaneseword,
"Englishword"=>$Englishword
));
}
}catch(PDOException $e){
 echo 'ERROR: ' . $e->getMessage();
}
echo 'hello';
}
myTest();
?>

You have a colon at the end of your query, not a semi-colon. Is this a typo on this post, or is it your problem? You also do not check if Japaneseword isset, but that probably isn't your issue. — Jordan
– Jordan, Commented Sep 12, 2013 at 22:51
Are $username and $password are being set inside the myTest() function as well or just placeholders for the question here? — Smith Smithy
– Smith Smithy, Commented Sep 12, 2013 at 23:53

Smith Smithy · Accepted Answer · 2013-09-13 15:26:35Z

1

you need to add the colon's to your execute array keys.

$result = $query->execute(array(
':Japaneseword'=>$Japaneseword,
":Englishword"=>$Englishword
));

EDIT: if this is not solving the problem AND you removed the colon from the end of your query string (you have ):"; ), then the next step is to check your post data

//put this at the top of the script and make sure all your post 
//variables are set as expected
echo '<pre>';
print_r($_POST);
echo '</pre>';

edited Sep 13, 2013 at 15:26

answered Sep 12, 2013 at 22:51

Smith Smithy

5956 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

user1864610 Over a year ago

@SmithSmithy It was not me who downvoted you, although your initial comment was worthy of it.

Smith Smithy Over a year ago

No worries. I did submit a one liner in error and then went back to paste in the revised code block.

Louis345 Over a year ago

I'm trying that and still not getting any data into my database.

Funk Forty Niner Over a year ago

@SmithSmithy I hardly if ever downvote anyone. I rather point it out first and hopefully add to an answer in order to provide accurate information for the OP/all. ;-)

Smith Smithy Over a year ago

at user1459917, bummer... see my revised answer. have you done this already?

|

user1864610 · Accepted Answer · 2013-09-12 22:51:43Z

1

You need to precede the token names in your array with a colon, like this:

$result = $query->execute(array(
 ':Japaneseword'=>$Japaneseword,
 ":Englishword"=>$Englishword
));

answered Sep 12, 2013 at 22:51

user1864610

Collectives™ on Stack Overflow

Inserting data into a Database using PHP (errors but doesn't insert anything);

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related