0

So, I got my PHP script to store input in a .txt file, however, something is not working with my html page. I want to output text to both a .txt file as well as a div on my html page.

I personally think it has to do with the fact that the script itself is on a separate page and I'm refreshing the page so there is never an opportunity to show up. I feel like what the PHP script should do is pull from the .txt file instead. But not sure.

I've tried action="" and putting the PHP on the same page but that didn't write to the .txt file. The ONLY way it has written to the .txt file is when I do action="[php file]".

Any ideas?

HTML:

The reference:

<?php require_once('storeText.php');?>

The Form:

<form id="post" name="post" action="storeText.php" method="post">
    <textarea name="msg" rows="5"></textarea>
    <input class="button" name="submit" type="submit" value="SQUAWK!"/>
</form>

Where I want the input to go on the page:

<div class="menuItem" >
    <?php echo $msg; ?>
</div>

PHP:

storeText.php 

<?php       

    if ( isset( $_POST['submit'] ) ) {
       $filename = 'posts.txt';
       $msg = (isset($_POST['msg']) ? $_POST['msg'] : null);

       if ( is_writable( $filename ) ) {
          if ( $handle = fopen( $filename, 'a') ) {
             fwrite( $handle, $msg );
             echo "Success, wrote ( $msg ) to file ( $filename )";
             fclose( $handle );
          } else {
             echo "Could not open file.";
          }
       } else {
          echo "File not writable.";
       }
       header("Location: profile.html");
    }
?>

FYI- I decided to use an alternate script for all the fwrite() haters out there... same deal... won't write to html page.

ALTERNATE PHP:

<?php       
if(isset($_POST['submit'])) 
{
    $file = 'posts.txt';
    // Open the file to get existing content
    $msg = file_get_contents($file);
    // Append new content to the file
    $msg .= (isset($_POST['msg']) ? $_POST['msg'] : null);
    // Write the contents back to the file
    file_put_contents($file, $msg);
    header("Location: profile.html");
}
?>
Improve this question
4
  • action="" and putting the PHP on the same page is working for me with file also. You want to display the msg on the same page then why are you redirecting to profile.html ? Commented Sep 13, 2013 at 7:46
  • @NikhilPatel I redirect to profile.html because if not, then when I hit submit a blank page comes up. Commented Sep 13, 2013 at 13:02
  • @NikhilPatel I'd like to input to the text file so that the message isn't lost, but is displayed on the same page even after the reload. Commented Sep 13, 2013 at 13:41
  • Yes. Put your PHP code on the same page as the form with action="" and display the message as you've specified in <div class="menuItem" >. It'll work Commented Sep 13, 2013 at 13:57

2 Answers 2

Reset to default
2

Nikhil Patel pretty much beat me to this in the comments on your question, but let me try to offer some more detail.

I'm not 100% sure I'm reading your question correctly, so correct me if I'm wrong on any of this: You have a form on profile.html, which sumbits to storeText.php. StoreText.php writes the file and redirects back to profile.html. Then you want profile.html to display the same $msg variable that got written to the text file, but it isn't doing that. Is that right?

You may have a problem with expecting a .html file to be executed as PHP code. I don't know how your Web server is set up, but normally only .php files are parsed by PHP. You might try renaming profile.html to profile.php and see if that makes a difference. From here on out, I'll be assuming that profile.html is being parsed as PHP; if I'm wrong about that, you'll probably have to rename the file.

The real problem is the redirect. You could take either of two different approaches here. One way to do it would be to include storeText.php in profile.html and have the form submit to profile.html. Then the $msg variable would be available in profile.html and should display. The other approach would be a POST/redirect/GET setup in which the form submitted to storeText.php, which did the work and redirected the user back to profile.html.

The thing is, you can't do both the include and the redirect. That's where you're running into problems. See, each HTTP request from the client, including the new request that the client sends in response to the redirect header, causes your script to be run again from scratch. The brand new profile.html that starts up after the redirect has never seen the $msg variable that contained the value that was written to the file. The reason submitting to profile.html didn't work is that it includes all the code from storeText.php, including the redirect, and even if you redirect to the same file, it's still a new request.

If you want to use the redirect, you'll need some way of storing that variable on the server side so that profile.html can get to it. The usual way of doing this is with sessions. Just have both profile.html and storeText.php set up sessions, have storeText.php save $msg to the session, and have profile.html pull it back out. Then remove the require_once('storeText.php'); line from profile.html, since you don't need that logic there anymore.

If you're not attached to the redirect, then you can do what I normally do (and what Nikhil Patel suggested in the comments). I normally put my form-displaying logic and my form-processing logic in one file, which decides what to do based on whether there's form input. I find this makes it easier to do validation, among other things, but I digress. All you really have to change here is to have the form submit to profile.html (action="" will work fine) and remove the redirect from storeText.php. Then everything will work as you expect.

However, both these approaches are completely wrong if the whole point of what you're doing is to make profile.html output whatever's in the text file, regardless of whether or not you're seeing it right after the form submission. In that case, don't worry about keeping that $msg variable at all. Keep storeText.php pretty much as it is, including the redirect. Remove the include from profile.html. Then, instead of having profile.html just try to echo $msg, have it open the file and echo its contents. (You can even set up a loop to read in one line at a time and put each one in a separate div if you want.)

On re-reading your question, I can't quite tell which behavior you actually want. Your first version of storeText.php only stores the new content in $msg, and uses the fopen/fwrite/etc. functions to append it to the file. So if $msg did survive the redirect (e.g. if you stored it in a session), the user would only see the new bit that was added to the file. The alternate version loads the file into $msg, appends the new content to that, and overwrites the file with $msg. If $msg survived the redirect in that case, the user would see the entire contents of the file.

However, in either case, the user would only see the results right after submitting the form; a fresh GET request to profile.html would still show an empty div. If you want the information to be displayed any time a user views profile.html, reading it from the file is the only option.

By the way, you may already know this but it is worth making explicit anyway: Do not display any values you got from the user without escaping them. If you do, then your page will allow an attacker to input malicious code and have it run in your users' browsers. This applies whether you got the values from the last form input or from a file. Read up on cross-site scripting (XSS) at IT Security StackExchange or OWASP.org.

Improve this answer
Sign up to request clarification or add additional context in comments.

3 Comments

Hey, I appreciate the lengthy response. It has been helpful. I decided to put everything in the same file to start off. My issue was the file was profile.html, when it should have been profile.php. I'll consider adding in a line to my .htaccess file to fix that (like addHandler or something similar). That fixed it. I put the php up at the top, removed the include, wrote action="" and it works. HOWEVER, what you wrote in your "HOWEVER" paragraph is ideally what I would like. I want to open the .txt file and spit out its contents on to separate divs.
I want to also add, that I don't want logic and html on the same page. So I'm going to keep storeText.php, remove the logic from profile.html, and figure out how to get profile.html to first push to the .txt with the submit, then pull the contents of the .txt file and put it onto the page, each comment in it's own div.
@Keven The file() function should do what you want. It will return an array of the lines of the file. Just use a foreach to iterate over that and echo each line into a div. To keep things nice and separate, I'd leave the redirect in storeText.php and keep the redirect as is; just remove the require_once() from profile.html. Then add a third file (fetchText.php maybe?) and include() or require() that in the part of profile.html where you want the lines to display.
0

Use File Put Content to store data on any file

Improve this answer

1 Comment

I can write to the file with the above script. My issue now is displaying the input in the same html page.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.