Converting string vector into custom object vector

Question

So I have a string vector values but I want to convert this vector into a vector of type Game, which is my own custom class. How would I go about this?

I'm trying something like this:

void set_games(vector <string> values){ 
    vector <Game> tmp(values.begin(), values.end()); 
    games = tmp;
}

but it's not working. Any suggestions?

Current error message:

no matching function for call to ‘Game::Game(const std::basic_string<char, std::char_traits<char>, std::allocator<char> >&)’
./classes/game.h:12: note: candidates are: Game::Game()
./classes/game.h:9: note: Game::Game(const Game&)

Update:

Added Game constructor parameter. Everything working as expected.

'its not working' In what way is it not working? Good grief! — john
– john, Commented Sep 13, 2013 at 22:18

john · Accepted Answer · 2013-09-13 22:21:46Z

4

Well the error message says it all. You need a constructor for Game that takes a single string argument.

class Game
{
public:
    Game(const std::string& s) { ... }
    ...

Once you've done that you could improve the efficiency of your code by ditching the tmp variable

games.assign(values.begin(), values.end());

Alternatively if another constructor isn't sensible from a design point of view then std::transform as Oli suggested.

answered Sep 13, 2013 at 22:21

john

88.3k5 gold badges61 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

us2012 Over a year ago

Just to make it clear, that constructor needs to contain all the logic to construct a sensible Game object corresponding to the string you pass. If you leave that constructor empty, you'll get a vector full of empty, useless Games.

Collectives™ on Stack Overflow

Converting string vector into custom object vector

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related