MySQL save error without error

Question

<?php
include("pass.php"); 
session_start();

if(isset($_SESSION["login"])) {
    require_once ('connect.php');

    $not = $_POST["not"];

    if($not=="") {
        header("location:mybbeklents/admin/dashboard.php?cmd=1");
    } else {
        mysql_query("INSERT INTO notlar (not,) VALUES ('$not')");
        header("location:mybbeklents/admin/dashboard.php?cmd=2");
    }
}
?>

This code doesn't work. They don't get saved into MySQL.

What error message do you get?

Rowland Shaw
– Rowland Shaw

2013-09-14 18:33:25 +00:00
Commented Sep 14, 2013 at 18:33 — Rowland Shaw
– Rowland Shaw, Commented Sep 14, 2013 at 18:33
According to the title: none?

dialogik
– dialogik

2013-09-14 18:33:41 +00:00
Commented Sep 14, 2013 at 18:33 — dialogik
– dialogik, Commented Sep 14, 2013 at 18:33

Jasmin Mistry · Accepted Answer · 2013-09-14 18:33:42Z

1

query should be

mysql_query("INSERT INTO notlar (`not`) VALUES ('$not')");

answered Sep 14, 2013 at 18:33

Jasmin Mistry

1,4861 gold badge19 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

herrjeh42 Over a year ago

please also change $not = mysql_real_escape_string($_POST["not"]); to avoid bad people dropping your database

dialogik · Accepted Answer · 2013-09-14 18:37:05Z

1

Try

mysql_query("INSERT INTO notlar (`not`) VALUES ('$not')")
OR die('MySQL error: '.mysql-error());

That echoes the error, if any occurs.

Note: Your query in insecure. Use mysqli or PHP PDO or at least unescape your variables before passing them to the query.

answered Sep 14, 2013 at 18:37

dialogik

9,59218 gold badges79 silver badges122 bronze badges

Comments

herrjeh42 · Accepted Answer · 2013-09-14 18:41:05Z

0

Change

$not = mysql_real_escape_string($_POST["not"]);

and

mysql_query("INSERT INTO notlar (not) VALUES ('$not')");

If this works, take your time and read a bit on sql injection and the outdated mysql extension. It is really easy to drop your database the way your code looks right now. You can solve both issues in your code using PDO. you'll find more information on PDO here: http://www.phptherightway.com/#security

answered Sep 14, 2013 at 18:41

herrjeh42

2,7934 gold badges36 silver badges49 bronze badges

Collectives™ on Stack Overflow

MySQL save error without error

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related