RUBY no method error for class method

Question

writing a rational class and i'm getting an error although I can't see anything wrong with my code. here is the class&relevant method:

class Rational
    attr_reader :numerator, :denominator     

    def initialize(numerator=1,denominator=1)
        @numerator = numerator
        @denominator = denominator
        reduce
    end

    class << self   

        def lcd(r1,r2)
               ...
                       ...
        end

        def add(r1,r2)
            if r1.denominator != r2.denominator
                lcd(r1,r2)
            end
            Rational r = Rational.new(r1.numerator + r2.numerator, r1.denominator)
            r1.reduce
            r2.reduce
            return r
        end


end
r = Rational.new
r2 = Rational.new(1,3)
r3 = Rational.new(1,4)
r = Rational.add(r2,r3)

the error I get :

rational.rb:53:in `add': undefined method `Rational' for Rational:Class (NoMethodError)

thanks in advance!

Sergio Tulentsev · Accepted Answer · 2013-09-17 06:05:22Z

1

Are you coming from Java? In ruby you don't have to specify variable type in declaration

Rational r = Rational.new(r1.numerator + r2.numerator, r1.denominator)

should be

r = Rational.new(r1.numerator + r2.numerator, r1.denominator)

answered Sep 17, 2013 at 6:05

Sergio Tulentsev

231k43 gold badges381 silver badges373 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

private_nodez Over a year ago

Thank you! This worked. Yes, I'm a ruby novice, I just started yesterday. I'm much more familiar with C++ and java

7stud · Accepted Answer · 2013-09-17 06:05:24Z

0

In ruby, you don't declare types:

Rational r = ...

Wrong! Ruby interprets that as the method call Rational() with the argument r.

answered Sep 17, 2013 at 6:05

7stud

48.8k14 gold badges107 silver badges137 bronze badges

1 Comment

private_nodez Over a year ago

Thanks, it worked =)! I'm new to ruby, what do you mean just write r?

Collectives™ on Stack Overflow

RUBY no method error for class method

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related