For loop issue in razor

Question

I am working on asp.net mvc4 and i am using razor for displaying data in my view.I am using one for loop in my view.my loop code is like below.

 **@for (int i = 0; i < 5; i++)
 {
    if (i<(@Html.DisplayFor(m => m.ProductInfo[5].Value)))
   {
     <img src="../../Images/star-on.png" />
   }
    else
    {
      <img src="../../Images/star-off.png" />
    }
  }**

In my above for loop in if condition i am trying to bind the number like 4.But it gives error like below

operator ' ' cannot be applied to operands of type 'int' and 'system.web.mvc.mvchtmlstring'

But when i display this razor code in my view like its showing the number "4".The code is like below.

@Html.DisplayFor(m => m.ProductInfo[5].Value)

i<(@Html.DisplayFor(m => m.ProductInfo[5].Value)) Why are you comparing a number to HTML? Why do you expect it to work? Is <span> greater than or equal to 6? — ta.speot.is
– ta.speot.is, Commented Sep 19, 2013 at 8:52

NinjaNye · Accepted Answer · 2013-09-19 09:07:58Z

2

You need to check against the value not the display for the value

 @for (int i = 0; i < 5; i++)
 {
    if (i < Model.ProductInfo[5].Value)  @* <-- This line changed *@
   {
     <img src="../../Images/star-on.png" />
   }
    else
    {
      <img src="../../Images/star-off.png" />
    }
  }

Update

If your Model.ProductInfo[5].Value is of type string you need to do the following (providing you are not willing to change Value's type)

 @{
     int productFiveValue;
     bool canConvert = Int32.TryParse(Model.ProductInfo[5].Value, out productFiveValue);
 }
 @for (int i = 0; i < 5; i++)
 {
     if (canConvert && i < productFiveValue)
     {
         <img src="../../Images/star-on.png" />
     }
     else
     {
          <img src="../../Images/star-off.png" />
     }
 }

edited Sep 19, 2013 at 9:07

answered Sep 19, 2013 at 8:53

NinjaNye

7,1361 gold badge34 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user2534261 Over a year ago

mr NinjaNye Its now giving me the error like operator ' ' cannot be applied to operands of type 'int' and 'string'

NinjaNye Over a year ago

Below your answer? I can't see it?

NinjaNye Over a year ago

Is ProductInfo[5].Value of type string

user2534261 Over a year ago

i tried (i < Model.ProductInfo[5].Value).Count() it's giving me different value.

NinjaNye Over a year ago

Glad to help. Please upvote or accept the answer if that is the case.

Ufuk Hacıoğulları · Accepted Answer · 2013-09-19 08:53:10Z

1

You don't need an HTML helper here, they usually return MvcHtmlString instances and you can't compare them to numbers. This should work:

if (i < Model.ProductInfo[5].Value)

answered Sep 19, 2013 at 8:53

Ufuk Hacıoğulları

38.6k14 gold badges120 silver badges157 bronze badges

4 Comments

user2534261 Over a year ago

mr NinjaNye Its now giving me the error like operator ' ' cannot be applied to operands of type 'int' and 'string'

Ufuk Hacıoğulları Over a year ago

@user2534261 What returns from Model.ProductInfo[5].Value?

user2534261 Over a year ago

it returns "4" number

Ufuk Hacıoğulları Over a year ago

@user2534261 as an int?

Collectives™ on Stack Overflow

For loop issue in razor

2 Answers 2

5 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related