PHP loop for number of posts in wordpress

Question

I need to create a slider navigation which has one li for each post. I currently have this code:

<?php
$args = array( 'post_type' => 'slides', 'orderby' => 'menu_order');
$loop = new WP_Query( $args );
?>

<div id="myCarousel" class="carousel slide">
  <ol class="carousel-indicators">

    <li data-target="#myCarousel" data-slide-to="0" class="active"></li>
    <?php while ( $loop->have_posts() ) : $loop->the_post();  $x = 1 ?>
    <li data-target="#myCarousel" data-slide-to="<?php echo $x ?>"></li>
    <?php $x = $x + 1 ?>
    <?php endwhile; ?>

  </ol>

As I need the first one to stay active.. But this isn't quite working for me

I'm getting one extra and they all say 1 so the number isn't getting bigger each time — Carla Dessi
– Carla Dessi, Commented Sep 23, 2013 at 21:35
I do need an iterator but it would probably be easier to loop through the post count? I just don't know how! — Carla Dessi
– Carla Dessi, Commented Sep 23, 2013 at 21:37

reikyoushin · Accepted Answer · 2013-09-23 23:12:46Z

1

try this:

** take note that the $x variable was moved outside the loop so that your data-slide-to value will not all be equal to 1;

<div id="myCarousel" class="carousel slide">
    <ol class="carousel-indicators">

        <li data-target="#myCarousel" data-slide-to="0" class="active"></li>
        <?php $x = 1; ?>
        <?php while ( $loop->have_posts() ) : $loop->the_post(); ?>
            <li data-target="#myCarousel" data-slide-to="<?php echo $x++; ?>"></li>
        <?php endwhile; ?>
    </ol>
</div>

** if you are getting extras, it maybe because you have put a static

<li data-target="#myCarousel" data-slide-to="0" class="active"></li>

inside the loop, so what you might want could be this instead:

<div id="myCarousel" class="carousel slide">
    <ol class="carousel-indicators">
        <?php $x = 0; ?>
        <?php while ( $loop->have_posts() ) : $loop->the_post(); ?>
            <li data-target="#myCarousel" data-slide-to="<?php echo $x; ?>" <?php echo ($x++==0)?'class="active"':'';?>></li>
        <?php endwhile; ?>
    </ol>
</div>

edited Sep 23, 2013 at 23:12

answered Sep 23, 2013 at 21:41

reikyoushin

2,0212 gold badges24 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Mike Brant Over a year ago

You should note that the primary difference here is that you are setting $x = 1 BEFORE the loops, whereas before his code was resetting $x = 1 which each iteration.

Carla Dessi Over a year ago

this works but I still have one extra, the li that isn't in the loop probably should be.. but I need it to have the class "active"

reikyoushin Over a year ago

good thing i have edited the answer already.. i have just read your comment. pls tell me if it works now.

reikyoushin Over a year ago

although you dont do anything on your loop.. you could put the_content() or something inside the <li></li> tags.. that's what you want to do i guess.. because the current code would generate empty <li>'s, if im not mistaken..

reikyoushin Over a year ago

the code i gave will put the class="active" on the first element.. no need for extra variables.. ;)

|

Anagio · Accepted Answer · 2013-09-23 21:40:15Z

0

You can get the count like this

$posts = new WP_Query( $postargs );
$postcount = $posts ->post_count;

Now do echo $postcount; and you will have the number of posts.

answered Sep 23, 2013 at 21:40

Anagio

3,0759 gold badges47 silver badges81 bronze badges

Collectives™ on Stack Overflow

PHP loop for number of posts in wordpress

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related