Javascript code syntax incorrect, not a string

Question

How do I change the code syntax below, where is says infoAddress from a number into a string value? What syntax am I missing.

var html  = '<a onclick="selectMarker(' + i + '); selectAddress(' + infoAddress + ');">';

Do not build HTML in JavaScript. What are you really trying to do? — Ry-
– Ry- ♦, Commented Sep 30, 2013 at 13:54
and what do you mean a number to a string value? You are already outputting its value with what you are doing. You can mean make a 5 output as five can you? :O — Jamie Hutber
– Jamie Hutber, Commented Sep 30, 2013 at 13:57
@user2782160: Because it is usually to put into innerHTML, which is almost always wrong. Use the DOM. — Ry-
– Ry- ♦, Commented Sep 30, 2013 at 14:04

Michael Kunst · Accepted Answer · 2013-09-30 14:11:47Z

3

If I get your question right, you're trying to give the parameter for the selectAddress function as a string. For the parameter must be in quotes. As you're already in a string, you've got to escape the single quotes with a backslash.

var html  = '<a onclick="selectMarker(' + i + '); selectAddress(\'' + infoAddress + '\');">linkText</a>';

edited Sep 30, 2013 at 14:11

answered Sep 30, 2013 at 13:55

Michael Kunst

2,98828 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Michael Kunst Over a year ago

Maybe I'm not understanding the question. Here's a little fiddle with what I think the OP is trying to achieve: jsfiddle.net/EsmgT. If that's not it, I'm happy to delete my answer again.

freefaller Over a year ago

@Michael, you have not just misunderstood the question, but you appear to have a misunderstanding of javascript syntax... what you have written is simply invalid code. (Edit: and your JSFiddle doesn't even produce a link)

Ry- Over a year ago

@freefaller: Maybe you didn’t understand where he meant to put it? var html = '<a onclick="selectMarker(' + i + '); selectAddress(\'' + infoAddress + '\');">';

freefaller Over a year ago

@minitech, you're correct - my apologies Michael... it wasn't at all obvious, and I'm having a bad day... I retract my objections (although the fiddle still doesnt' work)

Michael Kunst Over a year ago

Thank you. But I still can't really tell if this is actually what the OP asked for.

|

Collectives™ on Stack Overflow

Javascript code syntax incorrect, not a string

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related