Rails: how should I share logic between controllers?

Question

This question must have been asked already, but I can't find it.

I have a UsersController and an Admin::UsersController. Obviously a lot of what goes on in these classes (eg the implementation of strong_parameters, the paths to follow after creating/editing a user) are the same.

Can I - indeed, ought I? - share code between these controllers? Is this what concerns are for? The examples I find for them online tend to deal with models.

Any guidance much appreciated.

are they really going to be the same? Can admins edit the same list of fields as a general user? Will they redirect to the same place? Seems logical that a user would redirect to their profile after editing themselves, and an admin would redirect to a user list. — sevenseacat
– sevenseacat, Commented Oct 8, 2013 at 1:13
@sevenseacat, in the long term, probably not. but it's useful to share the strong_params for now, now that there's no more attr_accessible at the model level, if i understand correctly — djb
– djb, Commented Oct 8, 2013 at 10:08

axsuul · Accepted Answer · 2013-10-08 01:02:21Z

13

Use concerns (put in app/controllers/concerns)

module UsersControllable
  extend ActiveSupport::Concern

  def new
  end

  def create
  end

  private
  def user_params
    # strong params implementation
  end
end

class UsersController < ApplicationController
  include UsersControllable
end

class Admin::UsersController < ApplicationController
  include UsersControllable
end

answered Oct 8, 2013 at 1:02

axsuul

7,5009 gold badges60 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

cortex · Accepted Answer · 2013-10-07 17:32:07Z

0

One way is using inheritance. Create a new controller:

class SharedUserController < ApplicationController
  # With shared code
end

And then:

class UsersController < SharedUserController
end

class Admin::UsersController < SharedUserController
end

Hope this help!

answered Oct 7, 2013 at 17:32

cortex

5,2543 gold badges34 silver badges42 bronze badges

Collectives™ on Stack Overflow

Rails: how should I share logic between controllers?

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related