JavaScript calling function is not working

Question

This is my piece of code and it is not working in the expected way. Can give me any idea what i have wrong

<html>
<body>
<form>
  <input type="submit" value="Check" onclick="f(x, y, z)"/>
</form>
</body>
<script type="text/javascript">

var x = prompt("Enter the number",""); 
var y = prompt("Enter the number","");
var z = prompt("Enter the number","");

function f(x, y, z)
{
    // first, check that the right # of arguments were passed.
    if (f.arguments.length != 3) {
        alert("function f called with " + f.arguments.length +
              "arguments, but it expects 3 arguments.");
        return null;
    }


}
</script>
</html>

In the future, you should say what the problem is. What did you expect and what is happening. — Jeff Storey
– Jeff Storey, Commented Oct 10, 2013 at 12:11
Hi, at the first, i am checking the arguments that was passed is matching the 3 arguments or not. But, still, it is not working.. Any idea? — Sakthivel
– Sakthivel, Commented Oct 10, 2013 at 12:17

TheMobileMushroom · Accepted Answer · 2013-10-10 12:28:43Z

3

the function you are calling will always have 3 arguments. maybe you want to check if the arguments are not empty?

if (x=='' || y=='' || z==''){}

edited Oct 10, 2013 at 12:28

answered Oct 10, 2013 at 12:21

TheMobileMushroom

1263 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jeff Storey · Accepted Answer · 2013-10-10 13:08:15Z

2

You should be checking arguments.length, not f.arguments.length

Edit: @TheMobileMushroom also pointed out that arguments length will be 3 even if the args are empty strings. You can change it to

if (!x || !y || !z)

Don't use arguments.length

edited Oct 10, 2013 at 13:08

answered Oct 10, 2013 at 12:11

Jeff Storey

57.4k75 gold badges245 silver badges414 bronze badges

5 Comments

Sakthivel Over a year ago

Hi dude, I am still facing the same problem. Any idea?

Jeff Storey Over a year ago

What is the problem? Is the function being called? What are the values of x, y and z?

Sakthivel Over a year ago

I am getting the value from the user through 'prompt'. Please see my code. For the function f(), i am getting the values from user.

Jeff Storey Over a year ago

I mean what behavior are you actually seeing? What apart of it is not working? Are you even getting into the function call?

Sakthivel Over a year ago

I am expecting the alert box when i am missing to give 3 arguments. But, I am not getting any alert when i dont enter exactly 3 arguments.

lcestari · Accepted Answer · 2013-10-10 12:47:54Z

0

Try to place the script tag before the form tag, so the x,y and z will be declared before.

answered Oct 10, 2013 at 12:47

lcestari

1785 bronze badges

Collectives™ on Stack Overflow

JavaScript calling function is not working

3 Answers 3

Comments

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related