Refactoring duplicate code into methods

Question

I am using Resharper for refactoring. What is this type of feature called when you have the same code in around 5 different events being called but you want to replace them with a method call? And place that code in that method.

All done automatically.

Thanks

It's been 13 years ... and resharper still does not provide class context duplicate code refactoring ... — StackHola
– StackHola, Commented Mar 15, 2023 at 9:31

Glorfindel · Accepted Answer · 2019-05-29 16:06:47Z

14

I've been working on a Resharper plugin that does what you are asking. That is, it scans your code, searching for sections that can be replaced by an existing method call. A section can be a whole method or just a part of a method. When it finds one, the lightbulb pops up and offers to replace said section with a call to the existing method.

_{(source: landofjosh.com)}

I call it AgentRalph. At this point it's not ready for production use, but I've been making a lot of progress and hope to make a release soon.

edited May 29, 2019 at 16:06

Glorfindel

22.8k13 gold badges97 silver badges124 bronze badges

answered Jan 6, 2010 at 5:18

Josh Buedel

1,86317 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jason · Accepted Answer · 2009-12-18 20:38:11Z

2

Extract Method.

answered Dec 18, 2009 at 20:38

jason

243k35 gold badges436 silver badges532 bronze badges

5 Comments

Shawn Mclean Over a year ago

how do i get all of them into the method at once? The same code is found in multiple events

jason Over a year ago

I don't think that can be done. But you can still achieve it easily. Extract the method once, copy and paste the method call from that extraction in the other places and rename the parameters as necessary. Or, use Resharper to extract one method for each time the code is duplicated and then delete all but one of the methods and replace the calls to the method that remains.

John Saunders Over a year ago

The canonical use of Extract Method is extract two chunks of near-duplicate code each into its own method; use other refactorings to make the two methods identical; replace a call to Method2 with a call to Method1; delete Method2. Of course, run your unit tests between each refactoring. Repeat until all duplications are gone.

Dherik Over a year ago

@jason, I don't think this is a good way. The advantage of the "extract method" discover what code is duplicated and extract the method by itself is not delegate this discover for the developer. This need to be done by the tool, like Eclipse do.

Vetras Over a year ago

this does not identify duplicated occurrences in the whole Class unfortunately. Only on the same method (same context?). Pitty. :)

Ira Baxter · Accepted Answer · 2013-01-17 15:05:05Z

1

See our C# CloneDR. While it doesn't replace redundant code with function calls, it does tell you where they are across very large system, and forms the essential abstraction (procedure body and parameters). The web link has example clone analyses for the C# equivalent of Hibernate (NHibernate).

edited Jan 17, 2013 at 15:05

answered Jan 12, 2010 at 0:01

Ira Baxter

95.9k24 gold badges188 silver badges357 bronze badges

Collectives™ on Stack Overflow

Refactoring duplicate code into methods

3 Answers 3

Comments

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related