Ruby - can I shorten this 7 line method that declares and returns an array

Question

Seems like this would be a fairly common pattern - declaring the array and returning it:

def self.show_day_rows(days, month, year, offset)
  daylines=[]
  1.step(days,7).each do |line_starts_with|
    daylines << CalDay.line_of_day_nums(month, year, line_starts_with, offset)
  end
  daylines
end

Is there a way to shorten this but still be legible?

You probably want to ask this on Code Review. It's for these sort of questions. — the Tin Man
– the Tin Man, Commented Oct 19, 2013 at 1:03
This question appears to be off-topic because it belongs on Code Review — sevenseacat
– sevenseacat, Commented Oct 19, 2013 at 3:37

tihom · Accepted Answer · 2013-10-19 00:46:18Z

2

def self.show_day_rows(days, month, year, offset)
  1.step(days,7).map do |line_starts_with|
    CalDay.line_of_day_nums(month, year, line_starts_with, offset)
  end
end

answered Oct 19, 2013 at 0:46

tihom

8,0032 gold badges27 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cary Swoveland · Accepted Answer · 2013-10-19 02:47:33Z

0

A slight variant of @tihorn's answer:

def self.show_day_rows(days, month, year, offset)
  1.step(days,7).inject([]) do |daylines, line_starts_with|
    daylines << CalDay.line_of_day_nums(month, year, line_starts_with, offset)
  end
end

answered Oct 19, 2013 at 2:47

Cary Swoveland

111k6 gold badges69 silver badges105 bronze badges

Collectives™ on Stack Overflow

Ruby - can I shorten this 7 line method that declares and returns an array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related