onClickListener onclicklistener Android Java programming

Question

When i click on the images it doesnt change the display textview, where did i go wrong?

    **List<ImageView> fields = new ArrayList<ImageView>();
    for(int i = 0; i < 64; i++) {
        try{
            id = R.id.class.getField("square" + (i+1)).getInt(0);
            views.add((ImageView)findViewById(id));
            ((View) fields).setOnClickListener(new View.OnClickListener() {

                @Override
                public void onClick(View fields) {
                    for(int i=0; i < 64; i++)
                    {
                        display = (TextView) findViewById(R.id.textView1);
                        display.setText("square" + i);
                    }
                }
            });
        }
        catch(Exception e){}

    }**

}

}

use display.append(" \n square" + i); to check textview text is updating or not — ρяσѕρєя K
– ρяσѕρєя K, Commented Oct 20, 2013 at 16:35
it should display the square clicked. it's a chess game where i got 64squares. example if i click the first square it should show square1 and the last square63 — Rownie
– Rownie, Commented Oct 20, 2013 at 16:39
as zymurgeek has mentioned , you are doing wrong operation on list. By catching exception you are suppressing the error that you could have easily identified. So donot catch generic exception — nandeesh
– nandeesh, Commented Oct 20, 2013 at 17:51
Managed to solve it Zymurgeeks answer worked i was just displaying it wrong so i didnt see that it actually worked. So thx alot! — Rownie
– Rownie, Commented Oct 20, 2013 at 18:42

Parag Chauhan · Accepted Answer · 2013-10-20 20:01:00Z

1

It looks like you're adding the onClick listener to the ArrayList of views, not the image you added. Change

 ((View) fields).setOnClickListener

to

 findViewById(id).setOnClickListener

edited Oct 20, 2013 at 20:01

Parag Chauhan

36k13 gold badges89 silver badges95 bronze badges

answered Oct 20, 2013 at 16:40

Zymurgeek

1697 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Rownie Over a year ago

Hi thx for the help but after i did what you said it is clickable but it only shows square63 on every square i click. what i want the OnClickListener to do is show square1 if i click square1 and so on.

Zymurgeek Over a year ago

There's another issue in the code. For each click, it iterates through 0-63 setting the text for the clicked image 64 times. So you only see the last set which is "square 63". In your loop, you need to compare the fields passed to onClick to the items in your ArrayList to see which image was clicked, then only issue a setText for the found item.

Collectives™ on Stack Overflow

onClickListener onclicklistener Android Java programming

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related