reading a file into a python dictionary

Question

I have a text file like this

128.220.251.50
130.79.48.57
203.110.240.191
128.220.251.50 208.94.63.193
128.36.233.154 
128.36.233.154 131.246.112.29
128.36.233.154 136.145.115.196
130.79.48.57 203.110.240.191
131.246.112.29 199.26.254.68
136.145.115.196 128.220.251.50
136.145.115.196 140.247.60.123
137.165.1.113 
137.165.1.113 128.220.251.50
137.165.1.113 128.36.233.154
137.165.1.113 130.79.48.57
140.247.60.123 137.165.1.113
199.26.254.68 136.145.115.196
203.110.240.191 131.246.112.29
208.94.63.193 140.247.60.123

I want to read this into a dictionary.This is the code.

def get_key_value(line):
  key, sep, value = line.strip().partition(" ")

  return key, value

with open("output.txt") as fd:    
    d = dict(get_key_value(line) for line in fd)

for key,value in d.iteritems():
    print str(key),str(value)

The following is the output for the print statement.

128.220.251.50 208.94.63.193
130.79.48.57 203.110.240.191
203.110.240.191 131.246.112.29
131.246.112.29 199.26.254.68
199.26.254.68 136.145.115.196
136.145.115.196 140.247.60.123
128.36.233.154 136.145.115.196
140.247.60.123 137.165.1.113
208.94.63.193 140.247.60.123
137.165.1.113 130.79.48.57

I have the following problem.If u consider the input there are three keys(or lines) stating with 137.165.1.113.But the print statement is printing just one of the them. not all key value pairs are saved in the dictionary. and also i want the lines with just one ip address in the input to be ignored which is done in this code.Thanks in advance.

Christian Ternus · Accepted Answer · 2013-10-28 01:17:21Z

2

Dictionaries don't work like that. When you assign a value to a key that already has a value, the previous value gets overridden.

Perhaps try making each dictionary value a list which you can then append to:

d = {}
with open("output.txt") as fd:
    for line in fd:
        if not line.count(' '): continue # Skip over non-splittable lines
        for k,v in line.split():
            if k in d:
                d[k].append(v)
            else:
                d[k] = [v] 

for key,value in d.iteritems():
    print str(key), " ".join(value))

edited Oct 28, 2013 at 1:17

answered Oct 28, 2013 at 0:55

Christian Ternus

8,48227 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

aIKid Over a year ago

Nice answer Chris. Was about to post mine when i see this :D

aIKid Over a year ago

Also, you forgot to declare line.

Mark Over a year ago

for k,v in get_key_value(line): ValueError: need more than 0 values to unpack I defined line

Christian Ternus Over a year ago

@aIKid Oops, added line

Community · Accepted Answer · 2020-06-20 09:12:55Z

1

Python dictionaries are sets: keys must be unique, you can't have multiple equals key. If you try to assign an already esisting key, it gets overridden (infact you have as value the last line with that key).
See http://docs.python.org/2/tutorial/datastructures.html#dictionaries

You can either use lists as values, and append the new value or use MultiDicts, special dictionaries that allow multiple equal keys.

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Oct 28, 2013 at 1:08

LeartS

2,9162 gold badges27 silver badges46 bronze badges

Comments

MRocklin · Accepted Answer · 2013-10-28 01:39:22Z

A functional solution using the toolz library

$ pip install toolz
$ python

>>> from toolz import groupby, valmap, first, second

>>> with open(filename) as f:
...     lines = [line.strip().split(' ') for line in f if ' ' in line]

>>> groupby(first, lines)
{'128.220.251.50': [['128.220.251.50', '208.94.63.193']],
 '128.36.233.154': [['128.36.233.154', '131.246.112.29'], ['128.36.233.154', '136.145.115.196']],
 '130.79.48.57': [['130.79.48.57', '203.110.240.191']],
 '131.246.112.29': [['131.246.112.29', '199.26.254.68']],
 '136.145.115.196': [['136.145.115.196', '128.220.251.50'], ['136.145.115.196', '140.247.60.123']],
 '137.165.1.113': [['137.165.1.113', '128.220.251.50'], ['137.165.1.113', '128.36.233.154'], ['137.165.1.113', '130.79.48.57']],
 '140.247.60.123': [['140.247.60.123', '137.165.1.113']],
 '199.26.254.68': [['199.26.254.68', '136.145.115.196']],
 '203.110.240.191': [['203.110.240.191', '131.246.112.29']],
 '208.94.63.193': [['208.94.63.193', '140.247.60.123']]}

>>> valmap(lambda L: map(second, L), _)
{'128.220.251.50': ['208.94.63.193'],
 '128.36.233.154': ['131.246.112.29', '136.145.115.196'],
 '130.79.48.57': ['203.110.240.191'],
 '131.246.112.29': ['199.26.254.68'],
 '136.145.115.196': ['128.220.251.50', '140.247.60.123'],
 '137.165.1.113': ['128.220.251.50', '128.36.233.154', '130.79.48.57'],
 '140.247.60.123': ['137.165.1.113'],
 '199.26.254.68': ['136.145.115.196'],
 '203.110.240.191': ['131.246.112.29'],
 '208.94.63.193': ['140.247.60.123']}

Collectives™ on Stack Overflow

reading a file into a python dictionary

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related