Add multiple rows into datatable with the same data without looping

Question

Is there a way to add multiple rows with the same content without loop?

The following is the code I am currently using to achieve this.

        DataTable dtMessageDetails = new DataTable("Private Message Details");
        for (int i = 0; i < 10; i++)
        {
            dtMessageDetails.Rows.Add("65E6BD38-2806-S15G-9DC5-9DE908333996", 3, 0, "News", "News", Convert.ToDateTime(DateTime.Now.ToString("yyyy-MM-dd")), "Publish", "mes", 0, 0, 0, "null", "null", "Active");
        }

And my datatable should looks like

enter image description here

I want to replace loop with some other approach may be LINQ.

I think I have to be more clear. I need fastest way to achieve that because the datatable will have more than 10000 rows. So for better performance, I like to avoid looping. — Sudha
– Sudha, Commented Oct 30, 2013 at 10:21
Linq will not be faster than simple loop (I think nothing will be faster than for loop). One question - why you need to create datatable with 10000 duplicated rows? — Sergey Berezovskiy
– Sergey Berezovskiy, Commented Oct 30, 2013 at 10:25
@Sudha: I guess what you're looking for is the most efficient way to insert duplicate rows in the database, since it is not possible to perform that without loops. A loop has got to exist somewhere! even if it is not in your code it will exist somewhere else (in a library or even in hardware!). — Thomas C. G. de Vilhena
– Thomas C. G. de Vilhena, Commented Oct 30, 2013 at 10:32

Sergey Berezovskiy · Accepted Answer · 2013-10-30 10:30:11Z

3

Linq is for querying data, not for inserting. You can prepare data with linq, but you will use same loop for adding rows, which will not be any faster. Thus you are inserting same data, I suggest you to prepare these data instead of creating new items array on each iteration:

DataTable dtMessageDetails = new DataTable("Private Message Details");
object[] items = { "65E6BD38-2806-S15G-9DC5-9DE908333996", 3, 0, "News", "News", 
                   Convert.ToDateTime(DateTime.Now.ToString("yyyy-MM-dd")), 
                   "Publish", "mes", 0, 0, 0, "null", "null", "Active" };

for (int i = 0; i < 10; i++)    
    dtMessageDetails.Rows.Add(items);

answered Oct 30, 2013 at 10:30

Sergey Berezovskiy

237k44 gold badges441 silver badges468 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 11:57:22Z

2

In addition to @lazyberezovsky's answer, I recommend you to use the DataRowCollection.Add Method (DataRow) method overload, which is slightly faster:

var itemArray = new object[] { 
    "65E6BD38-2806-S15G-9DC5-9DE908333996", 3, 0, "News", "News", 
    Convert.ToDateTime(DateTime.Now.ToString("yyyy-MM-dd")),
    "Publish", "mes", 0, 0, 0, "null", "null", "Active" };

for (int i = 0; i < 10000; i++)
{
    var r = dtMessageDetails.NewRow();
    r.ItemArray = itemArray;
    dtMessageDetails.Rows.Add(r);
}

If you intend to add the same rows to a new DataTable instance through your code, you might also get some performance improvement if you use the DataTable.Copy Method. Just create the rows above once in your code, then use the following to populate another datatable:

var dtMessageDetailsCopy = dtMessageDetails.Copy();

edited May 23, 2017 at 11:57

CommunityBot

11 silver badge

answered Oct 30, 2013 at 10:41

Alex Filipovici

32.8k7 gold badges60 silver badges81 bronze badges

1 Comment

Sergey Berezovskiy Over a year ago

Didn't know about NewRecordFromArray beast. Good point, skipping items array check will be faster

Collectives™ on Stack Overflow

Add multiple rows into datatable with the same data without looping

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related