javascript Whats wrong with this code

Question

my textarea and all its atributes is correct, but my javascript not right cannot set value of oTextbox3.

<html>
  <head>
    <title>Retrieving a Textbox Value Example</title>
  </head>
  <body> 
    <textarea rows="5" cols="25" name="txt2"></textarea> <br /> <textarea rows="5"  cols="25" name="txt3"></textarea>
    <br />
    <input type="button" value="Set Values" onclick="setValues()" />

    <script type="text/javascript">
      function setValues() { 
      var oTextbox2= document.getElementById("txt2");
      oTextbox2 = oTextbox2.value; oTextbox2 = oTextbox2.split(" ");
      oTextbox2 = oTextbox2.sort();

      var oTextbox3 = document.getElementById("txt3"); 
      oTextbox3.value = oTextbox2;
      } 
    </script>

  </body>
</html>

a good practice is to not change the type of a variable so if you declared (and even named) a var to be oTextBox2 you shouldn't change it to its value and than an array of words. — Dziad Borowy
– Dziad Borowy, Commented Nov 3, 2013 at 9:50
also you can do all this in a single line: oTextbox2.value.split(" ").sort(); — Dziad Borowy
– Dziad Borowy, Commented Nov 3, 2013 at 9:51
thanks for input, i just started javascript and i see that simplicity is the key when coding — user2949525
– user2949525, Commented Nov 3, 2013 at 9:55
This question is similar to: Difference between id and name attributes in HTML. If you believe it’s different, please edit the question, make it clear how it’s different and/or how the answers on that question are not helpful for your problem. — dumbass
– dumbass, Commented Jan 5 at 7:38

Tobias · Accepted Answer · 2013-11-03 09:46:30Z

2

You use document.getElementById but assign names to your DOM elements. Use id attributes instead:

<textarea rows="5" cols="25" id="txt2"></textarea> <br /> <textarea rows="5"  cols="25" id="txt3"></textarea>

answered Nov 3, 2013 at 9:46

Tobias

7,7671 gold badge30 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

LeSam · Accepted Answer · 2013-11-03 09:46:17Z

1

document.getElementById("txt3") will get the element by "ID", you used name="txt3" you should have use id="txt3" in your textarea

answered Nov 3, 2013 at 9:46

LeSam

1,2654 gold badges19 silver badges41 bronze badges

Comments

Paul Draper · Accepted Answer · 2013-11-03 09:45:29Z

0

Did you mean oTextbox3.value = oTextbox2.value?

And if you're using getElementById, then you need to use id, not name.

EDIT: Or use document.getElementsByName:

var oTextbox2 = document.getElementsByName('txt2')[0];

answered Nov 3, 2013 at 9:45

Paul Draper

84.2k53 gold badges216 silver badges303 bronze badges

3 Comments

user2949525 Over a year ago

it is easy to set value of textarea has an id atribute, but i dont know how to retrieve value of textarea if it only has a name attribute.

user2949525 Over a year ago

my final code with your help, works perfect. thank you <body> <textarea rows="5" cols="25" name="txt2"></textarea> <br /> <textarea rows="5" cols="25" name="txt3"></textarea> <br /> <input type="button" value="Set Values" onclick="setValues()" /> <script type="text/javascript"> function setValues() { var oTextbox2= document.getElementsByName("txt2")[0]; oTextbox2 = oTextbox2.value; oTextbox2 = oTextbox2.split(" "); oTextbox2 = oTextbox2.sort(); var oTextbox3 = document.getElementsByName("txt3")[0]; oTextbox3.value = oTextbox2; } </script> </body>

user2949525 Over a year ago

the idea is to sort everything in alphabetical order, when i use id, it works perfect, but when i use the name attribute it does not work

Collectives™ on Stack Overflow

javascript Whats wrong with this code

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related