Calling js function on button click isn't working

Question

Any reason why this isn't running when clicked? I can't seem to figure it out.

<button id="button-container-like" onclick="rate($(this).attr(\'id\'))"><span class="thumbs-up"></span>Like</button>

<script>
function rate(rating){
var data = 'rating='+rating+'&id=<?php echo $eventId; ?>&userid56=<?PHP echo $userid55; ?>';

$.ajax({
   type: 'POST',
   url: 'includes/rate.php', //POSTS FORM TO THIS FILE
   data: data,
   success: function(e){
   $(".ratings").html(e); //REPLACES THE TEXT OF view.php
}
});
}
</script>

well, are you getting any errors?

tckmn
– tckmn

2013-11-05 23:24:04 +00:00
Commented Nov 5, 2013 at 23:24 — tckmn
– tckmn, Commented Nov 5, 2013 at 23:24

JC Lizard · Accepted Answer · 2013-11-05 23:29:09Z

1

here you go:

<button id="button-container-like" ><span class="thumbs-up"></span>Like</button>

<script>
    jQuery(document).ready(function () {

        $("#button-container-like").click(function() {
            rate($(this).attr("id"));
        });

        function rate(rating) {
            var data = 'rating=' + rating + '&id=<?php echo $eventId; ?>&userid56=<?PHP echo $userid55; ?>';

            $.ajax({
                type: 'POST',
                url: 'includes/rate.php', //POSTS FORM TO THIS FILE
                data: data,
                success: function(e) {
                    $(".ratings").html(e); //REPLACES THE TEXT OF view.php
                }
            });
        }
    });


</script>

answered Nov 5, 2013 at 23:29

JC Lizard

1,0566 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marek Karbarz · Accepted Answer · 2013-11-05 23:28:18Z

0

If there's nothing else going on in this code, then remove the slashes from your onclick code. They are unnecessary and cause an error.

onclick="rate($(this).attr('id'))"

answered Nov 5, 2013 at 23:28

Marek Karbarz

29.4k6 gold badges55 silver badges73 bronze badges

1 Comment

Barmar Over a year ago

Or use the simpler this.id instead of $(this).attr('id').

Collectives™ on Stack Overflow

Calling js function on button click isn't working

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related