Replace all elements with another jquery

Question

I have written this simple JS module that replaces all the elements having a specific data attribute with a dropdown element. For example: If I have this:

<span class="testclass1 testclass2" data-what="itemBox"></span>

It will be replaced by a dropdown. All works fine i.e. conversion from the span element is being done in case there is just a single <span class="testclass1 testclass2" data-what="itemBox"></span> but if I add multiple span elements with data-what="itemBox" only one of these elements get replaced and others don't. Here is the JS Module that I have written:

(function(){

var mould = {

    partyBox        :   $.parseHTML('<select name="mouldedParty"><option value="-1" selected disabled>Select Party</option></select>'),
    iBox            :   $.parseHTML('<select name="mouldedItem"><option value="-1" selected disabled>Select Item</option></select>'),

    itemCSS     :    {
                        'padding'    : '10px',
                        'border'     : '1px solid #ccc',
                        'background' : 'whitesmoke',
                        'color'      : '#2d2d2d',
                        'cursor'     : 'pointer'
                      },        

    partyCSS    :     {
                        'padding'    : '10px',
                        'border'     : '1px solid #ccc',
                        'background' : '#368EE0',
                        'color'      : 'white',
                        'cursor'     : 'pointer'
                      },

    init            :   function (){ },

    process         :   function (container) {
                            mould.mouldParty(container);
                            mould.mouldItems(container);                            
                        },

    mouldParty      :  function(container){
                            var pBox     = $(mould.partyBox);
                            var pBoxes   = $(container).find('[data-what=partyBox]');

                            pBox.css(mould.partyCSS);
                            mould.replaceAllWith(pBoxes, pBox);
                        },

    mouldItems      :  function(container){
                            var iBox     = $(mould.iBox);
                            var iBoxes   = $(container).find('[data-what=itemBox]');

                            iBox.css(mould.itemCSS);
                            mould.replaceAllWith(iBoxes, iBox);
                        },                          

    replaceAllWith  :   function(prevEls, newEl){
                            $(prevEls).each(function(index, elem){
                                $(elem).replaceWith(newEl);
                            });         
                        }
};

mould.process('body');

})();

Can anyone please tell me whats wrong with the code? Why only one element is being replaced while I have written the code to replace all the elements?

JSFiddle Here: http://jsfiddle.net/DK2pe/1/

UPDATE: Added comments to the fiddle http://jsfiddle.net/DK2pe/2/

Matt Ball · Accepted Answer · 2013-11-09 07:06:49Z

2

You need to clone newEl for each replacement. As per the replaceWith API documentation:

the selected element replaces the target by being moved from its old location, not by being cloned.

Therefore, change your code roughly like so:

replaceAllWith  :   function(prevEls, newEl){
                        $(prevEls).each(function(index, elem){
                            $(elem).replaceWith(newEl.clone());
                        });         
                    }

answered Nov 9, 2013 at 7:06

Matt Ball

361k102 gold badges655 silver badges725 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arun P Johny · Accepted Answer · 2013-11-09 07:09:03Z

0

Try

$(prevEls).replaceWith(function(idx, el){
    return $(el).clone()
})

answered Nov 9, 2013 at 7:09

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

2 Comments

Matt Ball Over a year ago

Why the extra function?

Arun P Johny Over a year ago

@MattBall I removed the .each() loop

Collectives™ on Stack Overflow

Replace all elements with another jquery

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related