C# Stop-Process command of PowerShell

Question

I want to use Stop-Process command (of PowerShell) in c#. I know how to use "Get-Process" command, But in the case of stop-process we have to give arguments(process name). In my case I am taking arguments from user in textbox.

   private void button2_Click(object sender, EventArgs e)
    {
        PowerShell ps = PowerShell.Create();

        ps.AddCommand("Stop-Process -Name " + (textBox1.Text).ToString());


        ps.Invoke();
    }

What is the problem here? Do you get any errors or is anything behaving unexpected? — therealtbs
– therealtbs, Commented Nov 9, 2013 at 20:32
Yeah, Actually it's run time error : The term 'Stop-Process -Name ' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. — daniyalahmad
– daniyalahmad, Commented Nov 9, 2013 at 20:35

therealtbs · Accepted Answer · 2013-11-09 20:58:58Z

2

You have to add the argument seperately:

private void button2_Click(object sender, EventArgs e)
{
    PowerShell ps = PowerShell.Create();

    ps.AddCommand("Stop-Process");
    ps.AddParameter("Name", textBox1.Text);

    ps.Invoke();
}

Also you don't have to do textBox1.Text.ToString() because the text property is already a string

edited Nov 9, 2013 at 20:58

answered Nov 9, 2013 at 20:37

therealtbs

16210 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

daniyalahmad Over a year ago

Not Working :/ It still giving me Error : The term 'Stop-Process -Name notepad' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

therealtbs Over a year ago

I have missed a space in my initial edit, try it with this code now.

therealtbs Over a year ago

I hope you have a good reason to use Powershell, because it would be faster and easier using the System.Diagnostics.Process class.

therealtbs Over a year ago

That is weird, it seems to work for me just fine. Does your code look like mine?

Keith Hill · Accepted Answer · 2013-11-10 03:29:43Z

2

Try this:

ps.AddCommand("Stop-Process").AddParameter("Name", textBox1.Text);

You could use your original approach if you used AddScript instead:

ps.AddScript("Stop-Process -Name " + textBox1.Text); # Not recommended

However I would not recommend this approach because it opens up your script to injection attacks similar to SQL injection. What if someone types into the text box: "notepad; Remove-Item C:\ -r -force"? :-)

That said, even with the first approach you should check the user input to make sure folks are somewhat limited in the processes they can shut down. If they type in "svchost", they might have a bad day as their system becomes unstable.

edited Nov 10, 2013 at 3:29

answered Nov 9, 2013 at 23:55

Keith Hill

204k44 gold badges370 silver badges377 bronze badges

Collectives™ on Stack Overflow

C# Stop-Process command of PowerShell

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related