Rails How to call create method with post params from another method

Question

I have a users_controller create method that looks like this:

  def create
    @user = User.new(user_params)
    @user.update_auth_token = true
    @user.mark_as_read_confirmation = 1
    @user.hide_tagged_feeds = 1

    coupon_valid = false
    if user_params['coupon_code']
      coupon = Coupon.find_by_coupon_code(user_params['coupon_code'])
      coupon_valid = (coupon.present? && !coupon.redeemed)
    end

    if coupon_valid || !ENV['STRIPE_API_KEY']
      @user.free_ok = true
    end

    if params[:user] && params[:user][:password]
      @user.password_confirmation = params[:user][:password]
    end

    if @user.save
      unless @user.plan.stripe_id == 'free'
        deactivate_subscriptions = Feedbin::Application.config.trial_days + 6
        send_notice = Feedbin::Application.config.trial_days - 1
        TrialDeactivateSubscriptions.perform_in(deactivate_subscriptions.days, @user.id)
        TrialSendExpiration.perform_in(send_notice.days, @user.id)
        TrialEnd.perform_in(Feedbin::Application.config.trial_days.days, @user.id)
      end
      @analytics_event = {eventCategory: 'customer', eventAction: 'new', eventLabel: 'trial', eventValue: 0}
      flash[:analytics_event] = render_to_string(partial: "shared/analytics_event").html_safe
      sign_in @user
      redirect_to root_url
    else
      render "new"
    end
  end

I am posting some user data and other non-model related data to a separate method in the users_controller. My question is how can I call the create method and set the user_params based on the session variables I have prepared?

isn't this where you're supposed to make an association (belongs_to, has_one, etc.) ? I don't know how to do it exactly, but that might help. — macsplean
– macsplean, Commented Nov 10, 2013 at 21:33

Edgars Jekabsons · Accepted Answer · 2013-11-10 21:52:12Z

1

Emotional side note: Probably one or more kittens die when this code is run. I encourage You to check on some OOP patterns and completely refactor this method. A good introduction to logic extraction concept.

http://blog.codeclimate.com/blog/2012/10/17/7-ways-to-decompose-fat-activerecord-models/

Now to Your question. I am not sure what problems You are having with accessing session data, but actually that's easy. Just like this:

session[:some_field] = "lala"
session[:some_field]
# => "lala"

If You want to manually populate params from session before some controller method just use before_filter (Though sounds like a really bad idea and You are doing something wrong).

class UsersController < ApplicationController
  before_filter :populate_params, only: [ :some_controller_method_like_create ]


private  
  def populate_params
    params[:some_param] = session[:some_param]
  end
end

answered Nov 10, 2013 at 21:52

Edgars Jekabsons

2,86317 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tmartin314 Over a year ago

Sorry about the kitty's! I just inherited code and need to get her running. Thanks for your help.

Collectives™ on Stack Overflow

Rails How to call create method with post params from another method

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related