HTML to PHP echo error

Question

Im still new in PHP, HTML or Javascipt. Im trying to find solution about this problem.

I got this error

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING when trying to show <?php echo $_GET["q"]; ?> in echo.

Original Code

<input type="hidden" name="q" value="<?php echo $_GET["q"]; ?>" /><input type="submit" name="ResetPasswordForm" value=" Reset Password " />

when change to echo

echo "<input type=\"hidden\" name=\"q\" value=\"<?php echo $_GET[\"q\"]; ?>\" /><input type=\"submit\" name=\"ResetPasswordForm\" value=\" Reset Password \" />\n";

Can someone help me or explain why? Thank you..

John Conde · Accepted Answer · 2013-11-12 20:36:02Z

1

You can't have an echo statement inside an echo statement.

value=\"<?php echo $_GET[\"q\"]; ?>\"

should be

value=\"$_GET["q"]\"

or

value=\"" . $_GET["q"] . "\"

answered Nov 12, 2013 at 20:36

John Conde

220k100 gold badges464 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Tobias Over a year ago

You should also take care of escaping the user input, as this might lead to XSS issues.

John Conde Over a year ago

@TobiasZander That goes without saying. I just addressed their main issue.

j08691 · Accepted Answer · 2013-11-12 20:36:10Z

0

Change it to:

echo "<input type=\"hidden\" name=\"q\" value=\"" . $_GET['q'] . "\" /><input type=\"submit\" name=\"ResetPasswordForm\" value=\" Reset Password \" />\n";

answered Nov 12, 2013 at 20:36

j08691

209k33 gold badges269 silver badges281 bronze badges

Comments

Arthur Nicoll · Accepted Answer · 2013-11-12 22:03:35Z

The other answers below are right about your problem but you maybe need to get your head round how PHP used this way (aka Dynamic HTML) works. When the web server picks up the basic script, all the PHP is interpreted and executed. The resulting output is passed to the client(browser) for rendering. So if you are doing an echo to output a bit of html such as an input element, like your example, you don't need further PHP tags but there are different ways to skin a cat.

You could echo out all your html (icluding Javascript) line by line OR you can jump in and out of PHP - like you were kind of doing with the value attribute:

i.e:

echo "<input type=\"hidden\" name=\"q\" value=\"" . $_GET['q'] . "\" /><input type=\"submit\" name=\"ResetPasswordForm\" value=\" Reset Password \" />\n";

OR

<?php
:
...some PHP stuff ...
:
//then pop out of PHP to do your html raw (maybe with a little bit of PHP mixed in)
?>
<input type="hidden" name="q" value="<?php echo $_GET['q']?>" />
<input type="submit" name="ResetPasswordForm" value=" Reset Password " />
<?php
:
.... some more PHP stuff....
:
?>

How you mix it up depends on what is easiest for maintenance etc.

Collectives™ on Stack Overflow

HTML to PHP echo error

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related