same return variable for different functions

Question

I have lots of functions which is used for validations. Can I use same return varibale for all the functions?

function fn1() {
    if () {..
        first = true;
    } else {
        first = false;
    }
    return first;
}

function fn2() {
    if () {..
        second = true;
    } else {
        second = false;
    }
    return second;
}

function fn3() {
    if () {..
        three = true;
    } else {
        three = false;
    }
    return three;
}


$('#submitButton').click(function () {
    var returnVal = true;
    returnVal1 = fn1();
    returnVal2 = fn2();
    returnVal3 = fn3();

    if (returnVal1 && returnVal2 && returnVal3) {
        returnVal = true;
    } else {
        returnVal = false;
    }
    return returnVal;
});

Instead of these many variables like returnVal1, returnVal2 and returnVal3, can I use returnVal for all the function returns? Can I use a single variable for all the function returns?

Thanks

Just call one function? What exactly are you trying to do?

George
– George

2013-11-15 14:11:14 +00:00
Commented Nov 15, 2013 at 14:11 — George
– George, Commented Nov 15, 2013 at 14:11
You can return true/false from your function

sudhansu63
– sudhansu63

2013-11-15 14:11:44 +00:00
Commented Nov 15, 2013 at 14:11 — sudhansu63
– sudhansu63, Commented Nov 15, 2013 at 14:11

Sirko · Accepted Answer · 2013-11-15 14:18:41Z

4

You can drop the variables all together and just call your validation functions inside the if clause:

$('#submitButton').click(function () {
    if ( first() && second() && third() ) {
       return true;
    } else {
       return false;
    }
});

or shorter as @FishBasketGordo suggested, if the return value is the only thing you need:

$('#submitButton').click(function () {
    return first() && second() && third();
});

If the validation is rather computation heavy, this also saves you some time, as the if-clause is evaluated lazely.

edited Nov 15, 2013 at 14:18

answered Nov 15, 2013 at 14:11

Sirko

74.3k19 gold badges157 silver badges194 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

FishBasketGordo Over a year ago

Or just return first() && second() && third();

musefan · Accepted Answer · 2013-11-15 14:19:33Z

1

Yes you can, but if you want a single end variable that determines if any single one fails then I would recommend doing so like this:

var isValid = first();
if(!second())
    isValid = false;
if(!three())
    isValid = false;

That way you don't end up resetting an invalid flag with a subsequent result.

The benefits of this, is that if you have a lot of validation functions you can throw them into an array and write less code...

var validators = [first, second, three];//etc..
var isValid = true;
for(var i = 0; i < validators.length; i++){
    if(!validators[i]()){
        isValid = false;
        break;
    }
}
//do something with isValid

Or if you have a dedicated "validate all" function...

var validators = [first, second, three];
function validateAll(){
    for(var i = 0; i < validators.length; i++){
        if(!validators[i]()){ 
            return false;
        }
    }
    return true;
}

edited Nov 15, 2013 at 14:19

answered Nov 15, 2013 at 14:12

musefan

48.6k21 gold badges144 silver badges193 bronze badges

2 Comments

user1049057 Over a year ago

Yes..I have lots of validation functions..So in the first case..U mean I have to call all the functions inside and array? like var validators = [fn1, fn2, fn3, fn4]

musefan Over a year ago

@user1049057: Not call them inside the array, just declare them. But your example is correct: var validators = [fn1, fn2, fn3, fn4]; will work fine, but I guess you already know that based on you having accepted my answer

Pascamel · Accepted Answer · 2013-11-15 14:18:19Z

1

You can replace the last function by the following code

$('#submitButton').click(function(){
    return (first() && second() && third());
});

edited Nov 15, 2013 at 14:18

answered Nov 15, 2013 at 14:11

Pascamel

9536 gold badges18 silver badges28 bronze badges

1 Comment

Pascamel Over a year ago

Damn thanks for the heads up @Sirko, bad copy/paste, heading to the coffee machine right now

megawac · Accepted Answer · 2013-11-15 14:23:14Z

1

If your returnValues are primitives that are going to be combined, you can easily combine their assignments. In your code snippet you can write it as below if you'd prefer:

$('#submitButton').click(function () {
    var returnVal = first() && second() && third();

    return !!returnVal; //ensure boolean is returned
});

edited Nov 15, 2013 at 14:23

answered Nov 15, 2013 at 14:12

megawac

11.4k6 gold badges43 silver badges61 bronze badges

6 Comments

user1049057 Over a year ago

I tried if(first && second && three){returnVal = true;}else{returnVal = false;}..But that doesnt seem to be working..

megawac Over a year ago

@user1049057 first second and three are functions. You have to call them

user1049057 Over a year ago

I mean the return variables of those function first, second and three..I am trying to put the return variables of those function inside if condition and checking

megawac Over a year ago

Make sure you dont have name conflicts with your variable names and functions. If you want to update your question I'll update this answer

user1049057 Over a year ago

yes..return variables and the function names are different. I just created this as a sample

|

RahulOnRails · Accepted Answer · 2013-11-15 14:25:00Z

function validateFunction(){   
  var result;     
  // First Function Condition\
  if(First Function)
      { 
        result = true;
      else
        result = false;
      }
      checkTruFalse(result);

  // Second Function Condition
  if(Second Function)
      { 
        result = true;
      else
        result = false;
      }
      checkTruFalse(result);

   // Third Function Condition
   if(Third Function)
       { 
         result = true;
       else
         result = false;
       }
       checkTruFalse(result); 
   }
 }

 function checkTruFalse(result)
   {   
     if (result == false ){ alert('ERROR'); break; } 
   }

 $('#submitButton').click(function(){ validateFunction(); });

As per the situation you can pass another variable inside checkTruFalse function to set alert message about specific error.

function checkTruFalse(result, message ){
  alert('ERROR :: '+message);
}

checkTruFalse( result, 'Invalid Input for Numeric Value');

Collectives™ on Stack Overflow

same return variable for different functions

5 Answers 5

1 Comment

2 Comments

1 Comment

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

2 Comments

1 Comment

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related