Why can't I read my data from the array?

Question

I am reading data from a file and writing it into an array. This works but I can't seem to read it back out of the array properly. Where is the mistake?

int main(){

    struct mountain{
        char name[300];
        char height[5];
    };

    struct mountain mountainArray[8];

    fp = fopen("berge.txt", "r");

    if(fp == NULL) {
        perror("Error opening file");
        return(-1);
    }

    int i=0;
    while ( fgets(readLine, buflen, fp)){
        if(i<8){

            char * p;

            p = strtok (readLine,":");
            if (p != NULL){

                strcpy(mountainArray[i].name,p);
                p = strtok (NULL, ":");
                if (p != NULL)
                    strcpy(mountainArray[i].height,p);
            }

            i++;

        }
    }

    unsigned int f;
    for (f=0; f<8; f++){

        printf("%s\n", mountainArray[i].name);
    }
    fclose(fp);

    return 0;
}

Cheeseminer · Accepted Answer · 2013-11-18 13:31:36Z

2

in line

printf("%c\n", mountainArray[i].name);

I think you mean f for the index, not i.

(and Ivaylo is right - you want %s for strings.)

answered Nov 18, 2013 at 13:31

Cheeseminer

3,1281 gold badge24 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hans En Over a year ago

That did it how embarassing!

Vishal R Over a year ago

Please handle error conditions as well in the program @HansEn by using setting NULL value for structure members, else in for loop it would print out junk for rest of members.

Ivaylo Strandjev · Accepted Answer · 2013-11-18 13:27:31Z

0

You should print a string using %s format specifier not %c.

answered Nov 18, 2013 at 13:27

Ivaylo Strandjev

71.4k18 gold badges130 silver badges183 bronze badges

1 Comment

Hans En Over a year ago

Yeah. That prints me p@ every line. If I debug, I can see that the array is filled with data. I just can´t seem to read it back out.

Collectives™ on Stack Overflow

Why can't I read my data from the array?

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related