WordPress PHP if not equal to but if greater than

Question

I have a WordPress site where I am trying to dynamically create a comma separated list of values using PHP. However all of my lists have a comma at the end when they shouldn't and I can't seem to work out how to remove it.

My current code is;

$tcount=count($terms);
foreach($terms as $term){
    echo $term->name;
    if($tcount>1){
        echo ', ';
    }
}

There is a comma at the end where it should simply be blank. I tried the following code instead but it didn't work;

$tcount=count($terms);
foreach($terms as $term){
    echo $term->name;
    if(!$tcount==$tcount && $tcount>1){
        echo ', ';
    }
}

Does anyone know what I'm doing wrong?

Michał Rybak · Accepted Answer · 2013-11-19 01:30:44Z

2

Just trim the last comma:

$result = "";

$tcount=count($terms);
foreach($terms as $term) {
  // save output in temporary variable...
  $result .= $term->name;
  $result .= ', ';
}
echo substr($result, 0, -2);  // delete last two characters (", ")

answered Nov 19, 2013 at 1:30

Michał Rybak

8,7063 gold badges44 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Darren · Accepted Answer · 2013-11-19 01:31:26Z

0

You'd use rtrim()

Like this:

rtrim($string, ',');

Example

answered Nov 19, 2013 at 1:31

Darren

13.1k4 gold badges44 silver badges81 bronze badges

2 Comments

Michał Rybak Over a year ago

rtrim() for sure looks cleaner than my approach (substr()), but it won't work for OP's output string, take a look here. It should be rtrim($string, ', '), with space added. However, this will trim also last name, if it ends with comma - although this is unlikely, it's a little hidden side-effect that may be difficult to spot.

Darren Over a year ago

@MichałRybak good spot, I was going to go with the substr() way but thought OP wanted quick and clean, thank you for pointing out the rest!

Krunal Shah · Accepted Answer · 2013-11-19 05:39:05Z

0

you should try php's inbuilt function.

it will minimize the code and also the precise way

$output = array();
foreach($terms as $term){
  $output[] = $term->name;
}
echo implode(', ', $output);

thanks

answered Nov 19, 2013 at 5:39

Krunal Shah

1,42415 silver badges26 bronze badges

Collectives™ on Stack Overflow

WordPress PHP if not equal to but if greater than

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related