Add controls and event handlers dynamically C#

Question

I have tried to dynamically add panels and their event handlers using the code below.

However it does not seem to work (trigger the event when clicked) although it is similar to many of the available answers.

Please help if possible.

int items = 0;

private void Form1_Load(object sender, EventArgs e)
{
    ArrayList al = new ArrayList();

    foreach (KnownColor knowColor in Enum.GetValues(typeof(KnownColor)))
    {
        Color color = Color.FromKnownColor(knowColor);
        al.Add(color.Name);
    }

    foreach (string i in al)
    {
        addListItem(i);
    }
}

public void addListItem(string item)
{
    Panel pnlItem = new Panel();

    pnlItem.Location = new Point(0, items * 25);
    pnlItem.Name = "pnl" + item;
    pnlItem.Size = new Size(250, 25);
    pnlList.Controls.Add(pnlItem);

    Label lbl = new Label();
    lbl.Text = item;
    pnlItem.Controls.Add(lbl);

    pnlItem.MouseClick += new MouseEventHandler(pnlItem_MouseClick);

    items++;
}

void pnlItem_MouseClick(object sender, MouseEventArgs e)
{
    MessageBox.Show("panel was clicked");
}

No. That's fine. They can be contained inside other controls. — ispiro
– ispiro, Commented Nov 21, 2013 at 21:36
so how do i get this to work, because everything looks fine, but it doesn't trigger the event.. — thewikus
– thewikus, Commented Nov 21, 2013 at 21:38
Are you clicking on the panel itself or the label inside the panel? — Icemanind
– Icemanind, Commented Nov 21, 2013 at 21:38
you added the event only on item's mouseclick, you should be adding the mouseclick event handler even to the label — HappyLee
– HappyLee, Commented Nov 21, 2013 at 21:41
If you will add the following lines to your code you'll see how LarsTech's answer fixes your code: pnlItem.BackColor = Color.Blue; and: lbl.BackColor = Color.Red; And click on the blue area. — ispiro
– ispiro, Commented Nov 21, 2013 at 21:46

LarsTech · Accepted Answer · 2013-11-21 21:39:16Z

2

You are clicking on the label. Add that handler, too:

pnlItem.MouseClick += pnlItem_MouseClick;
lbl.MouseClick += pnlItem_MouseClick;

answered Nov 21, 2013 at 21:39

LarsTech

81.9k14 gold badges161 silver badges237 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

fafafooey · Accepted Answer · 2013-11-21 21:50:24Z

0

Yeah, you're either clicking the label or no part of the panel at all. I tried the code, it works, but do what the others have said and add a back color so you know where to click. Be aware the areas around the label may also register as the "label" even though it seems as though you are clicking on the panel itself, (the area directly below it especially).

answered Nov 21, 2013 at 21:50

fafafooey

1811 gold badge2 silver badges13 bronze badges

Collectives™ on Stack Overflow

Add controls and event handlers dynamically C#

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related