Function contains a loop which doesn't work when an input contains a non-integer char

Question

i have this function in my project:

void inputIntArray(int array[], int size){
j = size;
for(i=0;i<j;i++){
    printf("* Enter number #%d out of %d: ",(i+1),j);
    scanf("%d",&k);
    array[i] = k;
    }
}

It's supposed to fill an array, and works fine when integers are input, when something which is not an integer is being inputted it will just fill the remaining cells in the array with the last integer inputted and skip the whole project while only printing everything remaining...

Anyone knows what causes this error? Thanks!

EDIT: After changing to:

void inputIntArray(int array[], int size){
    int i = 0,j = 0,k = 0;
    j = size;
    for(i=0;i<j;i++){
        printf("* Enter number #%d out of %d: ",(i+1),j);
        if(scanf("%d",&k) != 1){
            break;
        }
        array[i] = k;
    }
}

I'm still experiencing the same error.....

The return value of scanf is the number of successfully read inputs. If you check that, you can act appropriately. You're expecting 1, if you don't get that, do something about it. — enhzflep
– enhzflep, Commented Nov 25, 2013 at 16:43

EmptyArsenal · Accepted Answer · 2013-11-25 16:40:20Z

1

What do you expect it to do if a non-integer is used as the input? It doesn't seem like it's an error skipping non-integer input, but the correct behavior. If you want it to keep working, you need to handle that error by checking what the user inputs. If the input is not what the program expects, it's up to the coder to resolve that or you'll get unexpected behavior.

answered Nov 25, 2013 at 16:40

EmptyArsenal

7,4964 gold badges40 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tony The Lion · Accepted Answer · 2013-11-25 16:40:51Z

1

Your error is the fact that your array is of type int. If you want some other type, you'll have to have an array of that type.

answered Nov 25, 2013 at 16:40

Tony The Lion

63.6k71 gold badges252 silver badges424 bronze badges

Comments

Fiddling Bits · Accepted Answer · 2013-11-25 16:43:47Z

1

You need to check if scanf() fails. If it does, because invalid data was entered, you have to flush the stdin buffer and repeat the scanf() again.

answered Nov 25, 2013 at 16:43

Fiddling Bits

8,9144 gold badges32 silver badges48 bronze badges

Comments

chessweb · Accepted Answer · 2013-11-25 16:42:14Z

0

The format specifier %d tells scanf to expect an integer. See e.g. here.

answered Nov 25, 2013 at 16:42

chessweb

4,6935 gold badges30 silver badges33 bronze badges

Collectives™ on Stack Overflow

Function contains a loop which doesn't work when an input contains a non-integer char

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related