Combine a string-array with the remove- and split-function, to only one line of code?

Question

How can this piece of code be shorten to only one line of code?

string[] result1 = content.Split('|');
string result2 = result1[1].Remove(0, 4);

Seriously sorry, but I'm at a loss right now.

Just join both lines: string result2 = content.Split('|')[1].Remove(0, 4); — user2480047
– user2480047, Commented Nov 28, 2013 at 17:21
Why do you want to only use a single line of code? (And do you still need both variables?) More context is definitely required here. — Jon Skeet
– Jon Skeet, Commented Nov 28, 2013 at 17:22
Jamming multiple logical steps into one line of code makes the code harder to read, debug and maintain. It doesn't run any faster and it is the mark of an amateur — Steve Wellens
– Steve Wellens, Commented Nov 28, 2013 at 17:26
And to what Steve said, you should add that, in this specific case, the reliability is potentially lower: string[] result1 = content.Split('|'); string result2 = ""; if(result1.Length > 1) result2 = result1[1].Remove(0, 4); Works always. The summarised version you are asking for crashes if | is not present in content. Reducing the length of the code can be good in some contexts, but not always. — user2480047
– user2480047, Commented Nov 28, 2013 at 17:31
i know, but i got stuck in my code, since I'm sitting here programming for hours. Could not remember how to solve it. Joining both lines together is propably what i needed and other information is not necessary. So, I assume combining those two lines of code will not inconvenience myself :-P — MrMAG
– MrMAG, Commented Nov 28, 2013 at 17:35

Habib · Accepted Answer · 2013-11-28 17:25:03Z

3

If you need to complete array back with first item modified.

string[] result = content.Split('|').Select((r, i) => 
                        new { Value = i == 0 ? r.Remove(0, 4) : r, Index = i })
                        .Select(r => r.Value)
                        .ToArray();

answered Nov 28, 2013 at 17:25

Habib

224k30 gold badges420 silver badges446 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

MrMAG Over a year ago

I know, it's not actually what I asked for, but I like this expression better. This keeps my array original, with small modifications. I adjusted accordingly the value from 0 to 1, because it is the second placeholder i need to modify. thank you

Habib Over a year ago

@MrMAG, Somehow I read var result instead of string result and I assumed that you needed a modified array. That is why I posted it. But consider Jon Skeet comment, having it on a single line doesn't improve readability

Casperah · Accepted Answer · 2013-11-28 17:21:33Z

3

string result2 = content.Split('|')[1].Remove(0, 4);

answered Nov 28, 2013 at 17:21

Casperah

4,5841 gold badge21 silver badges13 bronze badges

Comments

Rahul Tripathi · Accepted Answer · 2013-11-28 17:22:01Z

3

Try this by joining both the lines like this:-

string result2 = content.Split('|')[1].Remove(0, 4);

Although as Jon Skeet mentioned in the comments it looks very logical question as to why you want to do this? As it is highly recommended to write a readable code.

answered Nov 28, 2013 at 17:22

Rahul Tripathi

173k33 gold badges292 silver badges341 bronze badges

Comments

BRAHIM Kamel · Accepted Answer · 2013-11-28 17:24:28Z

3

a different answer try it

 public static class MyExtensions
   {
     public static string SplitRemove(this String str,int arrayIndex,int charToRemove)
     {
        return str.Split(new char[] { '|' },
                         StringSplitOptions.RemoveEmptyEntries)   [arrayIndex].Remove(0,charToRemove);
    }
}

answered Nov 28, 2013 at 17:24

BRAHIM Kamel

13.8k1 gold badge38 silver badges47 bronze badges

1 Comment

BRAHIM Kamel Over a year ago

ok you write it once and whenever you call it you have one line of code

kmas · Accepted Answer · 2013-11-28 17:23:20Z

1

string result2 = content.Split('|')[1].Remove(0, 4);

answered Nov 28, 2013 at 17:23

kmas

6,44913 gold badges44 silver badges63 bronze badges

1 Comment

Fedor Hajdu Over a year ago

This is a question about C#.

Collectives™ on Stack Overflow

Combine a string-array with the remove- and split-function, to only one line of code?

5 Answers 5

2 Comments

Comments

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related