Passing an array to function

Question

int avg(int *p);

int main()
{
    int i, average, mark[5];
    int arr[5];

    for(i = 0; i < 5; i++);
    {
        arr[i] = scanf_s("%d\n", &mark[i]);
    }
    average = avg(arr);
}

int avg(int *p)
{
    int j, total = 0, avg;

    for(j = 0; j < 5; j++)
    {
        total += p[j];
    }
    avg = total / 5;
    return avg;
}

This program did not cause any errors.But while running I am getting "Run-Time Check Failure #2 -stack around the variable "mark" was corrupted. Can some one please explain the reason behind this?

Another reason for Egyptian brackets/K&R style: you have a (probably unintended) semicolon after your for in main. — Kninnug
– Kninnug, Commented Nov 30, 2013 at 11:54

Sabareesh · Accepted Answer · 2013-11-30 11:58:05Z

1

why you are using semicolon at the end of for loop..?

for(i = 0; i < 5; i++);

remove that semicolon and check

answered Nov 30, 2013 at 11:58

Sabareesh

3,6152 gold badges26 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Eutherpy · Accepted Answer · 2013-11-30 11:59:53Z

1

for(i = 0; i < 5; i++);

I don't think you want that semicolon there!

answered Nov 30, 2013 at 11:59

Eutherpy

4,5818 gold badges47 silver badges75 bronze badges

Comments

deeiip · Accepted Answer · 2013-11-30 12:06:42Z

1

Firstly about the fix:

for(i = 0; i < 5; i++)
    {
        arr[i] = scanf_s("%d\n", &mark[i]);
    }

This is just okey. Now reason of Run-Time Check Failure #2 -stack around the variable "mark" was corrupted : when you run:

for(i = 0; i < 5; i++);

After this line i = 5 Now you are doing arr[i] = scanf_s("%d\n", &mark[i]); Now arr[5] is not a leagal area for you. This is the reason of your error.

answered Nov 30, 2013 at 12:06

deeiip

3,3793 gold badges25 silver badges33 bronze badges

Comments

glglgl · Accepted Answer · 2013-11-30 12:07:06Z

0

I'd like to add a little explanation to the other answers.

The for loop does essentially nothing, except incrementing i until it is n longer < 5.

So if you leave the for loop, you have i = 5, and this is used for accessing arr and mark. Neither arr[5] nor mark[5] is valid, so your error happens.

answered Nov 30, 2013 at 12:07

glglgl

91.5k13 gold badges157 silver badges230 bronze badges

Collectives™ on Stack Overflow

Passing an array to function

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related