Catch custom exception C++

Question

I have an exception class:

#ifndef OBJECTEXCEPTION_H_
#define OBJECTEXCEPTION_H_

class ObjectException: public std::logic_error
{
public:
    ObjectException (const std::string& raison)
            :std::logic_error(raison){};
};

class Object1Exception: public ObjectException
{
public:
    Object1Exception (const std::string& raison)
    : ObjectException(raison){};
};

#endif

I have a method which throw this exception:

void Object1::myMethod(int type) {
if (type == 0) {
    throw new Object1Exception(type);
}

...
}

Now I use this method:

try{
    obj1->myMethod(0);
}
catch(Object1Exception& error){

}

But I have this error

terminate called after throwing an instance of 'tp::Object1Exception*'

I don't understand why the exception is not caught.

Never say new in C++ unless you're an expert.

Kerrek SB
– Kerrek SB

2013-12-08 17:31:19 +00:00
Commented Dec 8, 2013 at 17:31 — Kerrek SB
– Kerrek SB, Commented Dec 8, 2013 at 17:31

Community · Accepted Answer · 2017-05-23 11:57:32Z

3

Code throw Object1Exception(type); without the new; you are throwing a pointer to an exception, not an exception itself.

^{BTW, as commented by polkadotcadaver, the error message was pretty clear, it told you about throwing an instance of some pointer type throwing an instance of 'tp::Object1Exception*'....}

edited May 23, 2017 at 11:57

CommunityBot

11 silver badge

answered Dec 8, 2013 at 17:28

Basile Starynkevitch

231k18 gold badges323 silver badges578 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2428400 Over a year ago

I just want to point out also that the error message told you exactly this - "tp::Object1Exception*", the * meaning pointer.

Collectives™ on Stack Overflow

Catch custom exception C++

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related