Recursive function for comment and reply PHP application

Question

I am having difficulty conceptualizing a recursive function for appending replies to comments, replies to replies, replies to replies to replies, etc.

This is my comments table:

enter image description here

Which SHOULD look something like this when rendered:

enter image description here

As it stands I can render each comment associated with the article_id (excluding those that are NOT NULL, of course):

$comments = $commentClass->fetch_article_comments($article_id);

foreach($comments as $comment) {

        $comment_id = $comment['comment_id'];   
        $member_id = $comment['member_id'];
        $comment_text = $comment['comment_text'];
        $comment_timestamp = timeAgo($comment['comment_timestamp']);  //get time ago

        //render comment using above variables
    }

Now I'm assuming I need to add a recursive function at the end of the above foreach statement, but I have yet to come up with anything remotely successful in appending the comments replies and the replies to each reply.

Can anyone help me accomplish this or perhaps point me in the right direction. I am not entirely familiar with recursive functions. I have done some scanning of the internet and on stackoverflow looking for something that helps, but haven't found anything helpful yet.

I did come across this post which recommended using a hierarchical database system, but I think I would prefer to use a php recursive function for this.

Thanks.

edit

By using the below answers I am only returning the results first comment and then it iterates and displays that one comment indefinitely. I can't figure out why?

My php:

function display_comments($article_id, $parent_id=0, $level=0) {
    global $comment;
    global $member;
    global $signed_in;
    global $username;

    $comments = $comment->fetch_article_comments($article_id, $parent_id);

    foreach($comments as $data) {
        $comment_id = $data['comment_id'];   
        $c_member_id = $data['member_id'];
        $comment_text = $data['comment_text'];
        $comment_timestamp = timeAgo($data['comment_timestamp']);  //get time ago

        $member_data = $member->fetch_member_data($c_member_id);
        $c_member_username = $member_data['member_username'];
        $c_member_avatar = $member_data['member_avatar'];

                //render HTML here

                $parent = $data['comment_parent'];
                display_comments($article_id, $parent, $level+1);

    }//end foreach

}//end display_comments()

and my PDO query:

public function fetch_article_comments($article_id, $parent_id) { //$page = (int)(!isset($_GET['page'])) ? 0 : $_GET['page'];

    if ($parent_id > 0) {
        $parent_id = "= $parent_id";
    } else {
        $parent_id = "IS NULL";
    }

    $query = $this->db->prepare("SELECT * FROM `comments2` WHERE `article_id` = $article_id AND `comment_parent` $parent_id ORDER BY `comment_timestamp` DESC");

    try{
        $query->execute();
        $comments = $query->fetchAll();                                     //returns an array
        $query->closeCursor();

        return $comments;

    } catch(PDOException $e){
        die($e->getMessage());
    }
}

Eugen Rieck · Accepted Answer · 2013-12-09 10:52:14Z

4

The core of the problem is this:

$comments = $commentClass->fetch_article_comments($article_id);

I assume, this function somwhere creates and runs SQL, that is similar to SELECT ... WHERE comments.article_id=$article_id. This is not sufficient - you need something like

$comments = $commentClass->fetch_article_comments($article_id, $parent_id);

that translates into SQL similar to SELECT ... WHERE comments.article_id=$article_id AND comments.comment_parent ($parent_id>0)?"=$parent_id":"IS NULL"

Now you can write your PHP function:

function display_comments ($article_id, $parent_id=0, $level=0) {
  $comments = $commentClass->fetch_article_comments($article_id, $parent_id);
  foreach($comments as $comment) {
        $comment_id = $comment['comment_id'];   
        $member_id = $comment['member_id'];
        $comment_text = $comment['comment_text'];
        $comment_timestamp = timeAgo($comment['comment_timestamp']);  //get time ago

        //render comment using above variables
        //Use $level to render the intendation level

        //Recurse
        display_comments ($article_id, $comment_id, $level+1);
    }
}

And finally call it with display_comments ($article_id);

edited Dec 9, 2013 at 10:52

answered Dec 8, 2013 at 23:05

Eugen Rieck

65.6k10 gold badges75 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Benjamin de Bos Over a year ago

yours is better than mine, probs :-)

Nick Law Over a year ago

Shouldn't $comments = $commentClass->fetch_article_comments($article_id, $parent_id); be $comments = $commentClass->fetch_article_comments($article_id, $parent_id = NULL); so that it defaults to NULL?

Benjamin de Bos Over a year ago

Nah, thats only when setting up a function. You can't do that on invoking.

Eugen Rieck Over a year ago

@NicholasLaw No, it shouldn't. PHP null and MySQL null are different, and additionally in SQL you need WHERE ... IS NULL but WHERE ...=0. So I run with a numeric argument and change to NULL in the SQL generation: comments.comment_parent ($parent_id>0)?"=$parent_id":"IS NULL"

Nick Law Over a year ago

@EugenRieck I'm getting an SQL error SQLSTATE[HY093]: Invalid parameter number: no parameters were bound. I'm assuming that is because I'm using PDO and the ? in your query is expecting a bound variable?

|

Benjamin de Bos · Accepted Answer · 2013-12-08 23:04:23Z

You could do something like:

function getCommentsForParent($parent="") {
   echo "<div class=\"comment\">";
   $db = get("select your db logics where parent = $parent");
   foreach ($db as $comment) {
      echo "print your comment in a box and make a div around the hole comments"
      getCommentsForParent($comment['parent_id']);
   }
   echo "</div>";
}

invoke function with getCommentsForParent()

With your code it should be something like:

function getCommentForParent($parent="") {
   global $commentsClass, $article_id;
   $comments = $commentClass->fetch_article_comments($article_id,$parent);
   foreach($comments as $comment) {
        $comment_id = $comment['comment_id'];   
        $member_id = $comment['member_id'];
        $comment_text = $comment['comment_text'];
        $comment_timestamp = timeAgo($comment['comment_timestamp']);  //get time ago
        getCommentForParent($comment['parent']);
    }
}

Look closely, ive adjusted your fetch article_comments. It now has a listener for $parent. Make sure that when your $parent = "", the class will only select the comments with empty parent.

invoke with getCommentsForParent()

It will automatically loop through the parent. Ofcourse this is highly conceptual but given your code you should get the hang of it.

Collectives™ on Stack Overflow

Recursive function for comment and reply PHP application

2 Answers 2

9 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related